Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(495)

Issue 453053002: Rename url_request_[context_]peer.* into url_request_[context_]adapter.* (Closed)

Created:
6 years, 4 months ago by mef
Modified:
6 years, 4 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Rename url_request_[context_]peer.* into url_request_[context_]adapter.* BUG=390267 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288441

Patch Set 1 : Fix java formatting #

Unified diffs Side-by-side diffs Delta from patch set Stats (+269 lines, -943 lines) Patch
M components/cronet.gypi View 1 chunk +4 lines, -4 lines 0 comments Download
M components/cronet/android/java/src/org/chromium/net/UrlRequest.java View 12 chunks +38 lines, -37 lines 0 comments Download
M components/cronet/android/java/src/org/chromium/net/UrlRequestContext.java View 6 chunks +17 lines, -17 lines 0 comments Download
M components/cronet/android/org_chromium_net_UrlRequest.cc View 16 chunks +72 lines, -56 lines 0 comments Download
M components/cronet/android/org_chromium_net_UrlRequestContext.cc View 5 chunks +38 lines, -36 lines 0 comments Download
A + components/cronet/android/url_request_adapter.h View 5 chunks +21 lines, -21 lines 0 comments Download
A + components/cronet/android/url_request_adapter.cc View 14 chunks +45 lines, -38 lines 0 comments Download
A + components/cronet/android/url_request_context_adapter.h View 4 chunks +14 lines, -14 lines 0 comments Download
A + components/cronet/android/url_request_context_adapter.cc View 9 chunks +16 lines, -16 lines 0 comments Download
D components/cronet/android/url_request_context_peer.h View 1 chunk +0 lines, -88 lines 0 comments Download
D components/cronet/android/url_request_context_peer.cc View 1 chunk +0 lines, -209 lines 0 comments Download
D components/cronet/android/url_request_peer.h View 1 chunk +0 lines, -145 lines 0 comments Download
D components/cronet/android/url_request_peer.cc View 1 chunk +0 lines, -258 lines 0 comments Download
M components/cronet/android/wrapped_channel_upload_element_reader.h View 3 chunks +3 lines, -3 lines 0 comments Download
M components/cronet/android/wrapped_channel_upload_element_reader.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
mef
Hi guys, take a look, I've renamed peers into adapters per Will's suggestion. thanks, -m
6 years, 4 months ago (2014-08-08 18:29:18 UTC) #1
mmenke
LGTM. Definitely agree that the new name is much better.
6 years, 4 months ago (2014-08-08 18:38:34 UTC) #2
mef
The CQ bit was checked by mef@chromium.org
6 years, 4 months ago (2014-08-08 18:41:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mef@chromium.org/453053002/20001
6 years, 4 months ago (2014-08-08 18:44:49 UTC) #4
commit-bot: I haz the power
6 years, 4 months ago (2014-08-08 21:36:23 UTC) #5
Message was sent while issue was closed.
Change committed as 288441

Powered by Google App Engine
This is Rietveld 408576698