Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1421)

Issue 453033005: Remove RenderLayerFilterInfo::m_dirtySourceRect (Closed)

Created:
6 years, 4 months ago by Julien - ping for review
Modified:
6 years, 4 months ago
CC:
blink-layers+watch_chromium.org, blink-reviews, blink-reviews-rendering, eae+blinkwatch, esprehn, jchaffraix+rendering, leviw+renderwatch, pdr., rune+blink, zoltan1
Project:
blink
Visibility:
Public.

Description

Remove RenderLayerFilterInfo::m_dirtySourceRect m_dirtySourceRect is duplicating the paint invalidation logic by storing the exact same information. On top of that, FilterEffectRendererHelper::prepareFilterEffect already gets the invalidation rect from |dirtyRect|. This change is covered by css3/filters/filter-repaint-*.html that were added with m_dirtySourceRect in https://bugs.webkit.org/show_bug.cgi?id=80323. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180107

Patch Set 1 #

Patch Set 2 : Fix build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -21 lines) Patch
M Source/core/rendering/FilterEffectRenderer.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/FilterEffectRenderer.cpp View 2 chunks +2 lines, -4 lines 0 comments Download
M Source/core/rendering/RenderLayer.cpp View 1 1 chunk +2 lines, -8 lines 0 comments Download
M Source/core/rendering/RenderLayerFilterInfo.h View 2 chunks +0 lines, -5 lines 0 comments Download
M Source/core/rendering/RenderLayerRepainter.cpp View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
Julien - ping for review
6 years, 4 months ago (2014-08-12 16:01:16 UTC) #1
dsinclair
lgtm
6 years, 4 months ago (2014-08-12 16:31:07 UTC) #2
Xianzhu
lgtm
6 years, 4 months ago (2014-08-12 17:28:11 UTC) #3
leviw_travelin_and_unemployed
LGTM.
6 years, 4 months ago (2014-08-12 18:03:54 UTC) #4
Julien - ping for review
The CQ bit was checked by jchaffraix@chromium.org
6 years, 4 months ago (2014-08-12 18:06:24 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jchaffraix@chromium.org/453033005/20001
6 years, 4 months ago (2014-08-12 18:07:45 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 4 months ago (2014-08-12 18:34:39 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-12 19:04:40 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/22337)
6 years, 4 months ago (2014-08-12 19:04:41 UTC) #9
Julien - ping for review
The CQ bit was checked by jchaffraix@chromium.org
6 years, 4 months ago (2014-08-12 21:32:16 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jchaffraix@chromium.org/453033005/20001
6 years, 4 months ago (2014-08-12 21:34:04 UTC) #11
commit-bot: I haz the power
6 years, 4 months ago (2014-08-12 22:13:49 UTC) #12
Message was sent while issue was closed.
Change committed as 180107

Powered by Google App Engine
This is Rietveld 408576698