Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Issue 453033004: Cleanup: Remove unneeded android extensions code in chrome/browser/ui. (Closed)

Created:
6 years, 4 months ago by Lei Zhang
Modified:
6 years, 4 months ago
Reviewers:
Devlin
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

Cleanup: Remove unneeded android extensions code in chrome/browser/ui. BUG=349436 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289221

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -116 lines) Patch
D chrome/browser/ui/android/extensions/extension_install_dialog_android.cc View 1 chunk +0 lines, -23 lines 0 comments Download
D chrome/browser/ui/android/extensions/extension_install_ui_android.h View 1 chunk +0 lines, -27 lines 0 comments Download
D chrome/browser/ui/android/extensions/extension_install_ui_android.cc View 1 chunk +0 lines, -44 lines 0 comments Download
D chrome/browser/ui/android/extensions/extension_view_android.cc View 1 chunk +0 lines, -18 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Lei Zhang
6 years, 4 months ago (2014-08-12 00:56:20 UTC) #1
Devlin
Yay code cleanup! If the bots are happy, I'm happy. LGTM.
6 years, 4 months ago (2014-08-12 15:22:10 UTC) #2
Lei Zhang
The CQ bit was checked by thestig@chromium.org
6 years, 4 months ago (2014-08-12 19:09:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/453033004/1
6 years, 4 months ago (2014-08-12 19:12:43 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_x64_rel on tryserver.chromium.win ...
6 years, 4 months ago (2014-08-13 02:46:45 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-08-13 09:05:53 UTC) #6
Message was sent while issue was closed.
Change committed as 289221

Powered by Google App Engine
This is Rietveld 408576698