Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(550)

Issue 453015: Update the Pepper APIs to the latest spec for the 2D demo plugin.... (Closed)

Created:
11 years ago by brettw
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Update the Pepper APIs to the latest spec for the 2D demo plugin. This also adds the npapi headers to the npapi.gyp file since I got tired of Visual Studio not finding the files. This removes the "open file in sandbox" feature which it doesn't look like we will use. One more significant change is that I changed to including pepper.h in all cases, even when pepper is disabled. We used to have a forward declare in npapi.h for the structs in question, but we'll be adding a lot more structs for the different contexts and I don't think this will scale. I think its OK fo rthe pepper API declarations to be available when Pepper isn't enabled. BUT=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=33501

Patch Set 1 #

Total comments: 4

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Patch Set 6 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+394 lines, -492 lines) Patch
M chrome/browser/renderer_host/resource_message_filter.h View 4 2 chunks +0 lines, -3 lines 0 comments Download
M chrome/browser/renderer_host/resource_message_filter.cc View 4 2 chunks +0 lines, -19 lines 0 comments Download
M chrome/common/render_messages.h View 4 2 chunks +0 lines, -20 lines 0 comments Download
M chrome/common/render_messages_internal.h View 4 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/renderer/webplugin_delegate_pepper.h View 4 3 chunks +17 lines, -10 lines 0 comments Download
M chrome/renderer/webplugin_delegate_pepper.cc View 4 3 chunks +120 lines, -124 lines 0 comments Download
M third_party/npapi/bindings/npapi.h View 4 1 chunk +0 lines, -7 lines 0 comments Download
A + third_party/npapi/bindings/npapi_extensions.h View 5 chunks +103 lines, -51 lines 0 comments Download
M third_party/npapi/npapi.gyp View 4 1 chunk +14 lines, -0 lines 0 comments Download
D webkit/glue/pepper/pepper.h View 4 1 chunk +0 lines, -179 lines 0 comments Download
M webkit/glue/plugins/nphostapi.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/glue/plugins/plugin_host.cc View 4 5 chunks +93 lines, -34 lines 0 comments Download
M webkit/glue/webplugin_delegate.h View 4 2 chunks +26 lines, -10 lines 0 comments Download
M webkit/tools/pepper_test_plugin/plugin_object.h View 4 1 chunk +2 lines, -0 lines 0 comments Download
M webkit/tools/pepper_test_plugin/plugin_object.cc View 4 4 chunks +18 lines, -27 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
brettw
11 years ago (2009-12-01 19:19:30 UTC) #1
sehr (please use chromium)
One header file merge. Otherwise nits. http://codereview.chromium.org/453015/diff/1/7 File src/third_party/npapi/bindings/npapi.h (right): http://codereview.chromium.org/453015/diff/1/7#newcode744 src/third_party/npapi/bindings/npapi.h:744: #if !defined(PEPPER_APIS_ENABLED) Why ...
11 years ago (2009-12-01 19:45:52 UTC) #2
brettw
New snap up with npapi_extensions.h containing the pepper extensions.
11 years ago (2009-12-01 22:08:43 UTC) #3
sehr (please use chromium)
On 2009/12/01 22:08:43, brettw wrote: > New snap up with npapi_extensions.h containing the pepper extensions. ...
11 years ago (2009-12-01 22:12:13 UTC) #4
nfullagar
11 years ago (2009-12-01 23:02:54 UTC) #5
thanks Brett, LGTM

Powered by Google App Engine
This is Rietveld 408576698