Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(789)

Side by Side Diff: chrome/common/variations/variation_ids.h

Issue 453013002: Reserve 100 ids for webrtc use in its finch experiments. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_COMMON_VARIATIONS_VARIATION_IDS_H_ 5 #ifndef CHROME_COMMON_VARIATIONS_VARIATION_IDS_H_
6 #define CHROME_COMMON_VARIATIONS_VARIATION_IDS_H_ 6 #define CHROME_COMMON_VARIATIONS_VARIATION_IDS_H_
7 7
8 namespace chrome_variations { 8 namespace chrome_variations {
9 9
10 // A list of Chrome Variation IDs. These IDs are associated with FieldTrials 10 // A list of Chrome Variation IDs. These IDs are associated with FieldTrials
(...skipping 317 matching lines...) Expand 10 before | Expand all | Expand 10 after
328 // Instant search clicks field trial. 328 // Instant search clicks field trial.
329 INSTANT_SEARCH_CLICKS_FIELD_TRIAL_ID_MIN = 3312322, 329 INSTANT_SEARCH_CLICKS_FIELD_TRIAL_ID_MIN = 3312322,
330 INSTANT_SEARCH_CLICKS_FIELD_TRIAL_ID_MAX = 3312371, 330 INSTANT_SEARCH_CLICKS_FIELD_TRIAL_ID_MAX = 3312371,
331 331
332 // iOS Phone modal dialog field trial. 332 // iOS Phone modal dialog field trial.
333 IOS_PHONE_NTP_MODAL_DIALOG_ENABLED_1 = 3312374, 333 IOS_PHONE_NTP_MODAL_DIALOG_ENABLED_1 = 3312374,
334 IOS_PHONE_NTP_MODAL_DIALOG_ENABLED_2 = 3312375, 334 IOS_PHONE_NTP_MODAL_DIALOG_ENABLED_2 = 3312375,
335 IOS_PHONE_NTP_MODAL_DIALOG_CONTROL_1 = 3312376, 335 IOS_PHONE_NTP_MODAL_DIALOG_CONTROL_1 = 3312376,
336 IOS_PHONE_NTP_MODAL_DIALOG_CONTROL_2 = 3312377, 336 IOS_PHONE_NTP_MODAL_DIALOG_CONTROL_2 = 3312377,
337 337
338 // Field trials can be queried directly from webrtc via webrtc::field_trial.
339 // Thus new trials are added without explicit CLs in chromium repository.
340 // This is the range of ids reserved for those trials.
341 WEBRTC_FIELD_TRIAL_RANGE_ID_MIN = 3312378,
342 WEBRTC_FIELD_TRIAL_RANGE_ID_MAX = 3312477,
343
338 // NEXT ID: When adding new IDs, please add them above this section, starting 344 // NEXT ID: When adding new IDs, please add them above this section, starting
339 // with the value of NEXT_ID, and updating NEXT_ID to (end of your reserved 345 // with the value of NEXT_ID, and updating NEXT_ID to (end of your reserved
340 // range) + 1. 346 // range) + 1.
341 NEXT_ID = 3312378, 347 NEXT_ID = 3312478,
342 348
343 // USABLE IDs END HERE. 349 // USABLE IDs END HERE.
344 // 350 //
345 // The largest possible Chrome variation ID in the reserved range. When 351 // The largest possible Chrome variation ID in the reserved range. When
346 // defining your variation IDs, DO NOT exceed this value - GWS will ignore 352 // defining your variation IDs, DO NOT exceed this value - GWS will ignore
347 // your experiment! 353 // your experiment!
348 MAXIMUM_ID = 3399999, 354 MAXIMUM_ID = 3399999,
349 }; 355 };
350 356
351 } // namespace chrome_variations 357 } // namespace chrome_variations
352 358
353 #endif // CHROME_COMMON_VARIATIONS_VARIATION_IDS_H_ 359 #endif // CHROME_COMMON_VARIATIONS_VARIATION_IDS_H_
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698