Issue 452963002: Added mojom.FixedArray to the array clause in JavaScriptEncodeSnippet(kind).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 452963002: Added mojom.FixedArray to the array clause in JavaScriptEncodeSnippet(kind). (Closed)

Created:
6 years, 4 months ago by hansmuller

Modified:
6 years, 4 months ago

Reviewers:
mpcomplete, Matt Perry, abarth-chromium

CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Added mojom.FixedArray to the array clause in JavaScriptEncodeSnippet(kind). Added a dependency on "mojo/public/interfaces/bindings/tests/validation_test_interfaces.mojom" to validation_unittests.js, just to prove that the bindings can be parsed. BUG=401977 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288474

Patch Set 1 #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -2 lines)			Patch
	M	mojo/public/js/bindings/validation_unittests.js	View		1 chunk	+2 lines, -1 line	0 comments	Download
	M	mojo/public/tools/bindings/generators/mojom_js_generator.py	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

hansmuller

Just a tiny fix so that the bindings generated for validation_test_interfaces.mojom will parse.

6 years, 4 months ago (2014-08-08 15:49:55 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hansmuller@chromium.org/452963002/1

6 years, 4 months ago (2014-08-08 19:20:58 UTC) #4

Message was sent while issue was closed.

Change committed as 288474

Expand Messages | Collapse Messages