Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(365)

Issue 452923004: [Android] Record UMA metrics after native initialization completes. (Closed)

Created:
6 years, 4 months ago by Feng Qian
Modified:
6 years, 4 months ago
Reviewers:
Yaron
CC:
chromium-reviews, erikwright+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

[Android] Record UMA metrics after native initialization completes. Discoverd that we never got LibraryLoader.NativeLibraryHack in UMA histograms server. Found that's because UMA session was not started yet right after native libraries are loaded. By delaying recording until UMA session is started, these stats shown up in chrome://histograms. BUG=311644 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289022

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M base/android/java/src/org/chromium/base/library_loader/LibraryLoader.java View 1 chunk +3 lines, -0 lines 2 comments Download

Messages

Total messages: 6 (0 generated)
Feng Qian
6 years, 4 months ago (2014-08-08 19:21:18 UTC) #1
Yaron
lgtm https://codereview.chromium.org/452923004/diff/1/base/android/java/src/org/chromium/base/library_loader/LibraryLoader.java File base/android/java/src/org/chromium/base/library_loader/LibraryLoader.java (right): https://codereview.chromium.org/452923004/diff/1/base/android/java/src/org/chromium/base/library_loader/LibraryLoader.java#newcode230 base/android/java/src/org/chromium/base/library_loader/LibraryLoader.java:230: public static void onNativeInitializationComplete() { Ideally you could ...
6 years, 4 months ago (2014-08-12 01:23:52 UTC) #2
Feng Qian
https://codereview.chromium.org/452923004/diff/1/base/android/java/src/org/chromium/base/library_loader/LibraryLoader.java File base/android/java/src/org/chromium/base/library_loader/LibraryLoader.java (right): https://codereview.chromium.org/452923004/diff/1/base/android/java/src/org/chromium/base/library_loader/LibraryLoader.java#newcode230 base/android/java/src/org/chromium/base/library_loader/LibraryLoader.java:230: public static void onNativeInitializationComplete() { Good to know the ...
6 years, 4 months ago (2014-08-12 16:47:01 UTC) #3
Feng Qian
The CQ bit was checked by feng@chromium.org
6 years, 4 months ago (2014-08-12 16:47:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/feng@chromium.org/452923004/1
6 years, 4 months ago (2014-08-12 16:50:03 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-08-12 18:08:55 UTC) #6
Message was sent while issue was closed.
Change committed as 289022

Powered by Google App Engine
This is Rietveld 408576698