CreateTrailsFromString function now accepts argument without last separator symbol

CreateTrailsFromString function accepts values for trails_string argument without last separator symbol

BUG=401298
Committed: https://crrev.com/4c4c9c73968ec4c1c28c48559d392e2d2c42cc6e
Cr-Commit-Position: refs/heads/master@{#295153}

[gayane -on leave until 09-2017, 2014-08-08 18:14:14]

I added special if in CreateTrailsFromString function to deal with the case when
the string finishes without separator symbol and changed the unittests for that
case.

[Alexei Svitkine (slow), 2014-08-08 18:28:48]

Looks good, just a few nits. Thanks!

https://codereview.chromium.org/452923003/diff/1/base/metrics/field_trial.cc
File base/metrics/field_trial.cc (left):

https://codereview.chromium.org/452923003/diff/1/base/metrics/field_trial.cc#...
base/metrics/field_trial.cc:423: 
Nit: Restore the existing whitespace as it was before here and on line 426.

https://codereview.chromium.org/452923003/diff/1/base/metrics/field_trial_uni...
File base/metrics/field_trial_unittest.cc (right):

https://codereview.chromium.org/452923003/diff/1/base/metrics/field_trial_uni...
base/metrics/field_trial_unittest.cc:401:
EXPECT_TRUE(FieldTrialList::CreateTrialsFromString(
Create a new test case for this, instead of grouping it in the existing one.

[gayane -on leave until 09-2017, 2014-08-08 18:50:17]

Done!

https://codereview.chromium.org/452923003/diff/1/base/metrics/field_trial.cc
File base/metrics/field_trial.cc (left):

https://codereview.chromium.org/452923003/diff/1/base/metrics/field_trial.cc#...
base/metrics/field_trial.cc:423: 
On 2014/08/08 18:28:48, Alexei Svitkine wrote:
> Nit: Restore the existing whitespace as it was before here and on line 426.

Done.

https://codereview.chromium.org/452923003/diff/1/base/metrics/field_trial_uni...
File base/metrics/field_trial_unittest.cc (right):

https://codereview.chromium.org/452923003/diff/1/base/metrics/field_trial_uni...
base/metrics/field_trial_unittest.cc:401:
EXPECT_TRUE(FieldTrialList::CreateTrialsFromString(
On 2014/08/08 18:28:48, Alexei Svitkine wrote:
> Create a new test case for this, instead of grouping it in the existing one.

Done.

[Alexei Svitkine (slow), 2014-08-08 19:00:09]

LGTM, thanks!

[gayane -on leave until 09-2017, 2014-08-08 19:35:56]

The CQ bit was checked by gayane@chromium.org

[commit-bot: I haz the power, 2014-08-08 19:38:50]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/gayane@chromium.org/452923003/20001

[commit-bot: I haz the power, 2014-08-08 22:55:25]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_dbg_triggered_tests on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tri...)

[commit-bot: I haz the power, 2014-08-08 23:18:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-08 23:18:53]

Try jobs failed on following builders:
  android_dbg_triggered_tests on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tri...)

[Alexei Svitkine (slow), 2014-09-16 19:30:27]

Looks like you never actually landed this.

[gayane -on leave until 09-2017, 2014-09-16 20:20:21]

The CQ bit was checked by gayane@chromium.org

[commit-bot: I haz the power, 2014-09-16 20:21:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/452923003/20001

[commit-bot: I haz the power, 2014-09-16 21:59:13]

Committed patchset #2 (id:20001) as 8dfb59d4c404cd7c6d636f2263d42526c42735f1

[commit-bot: I haz the power, 2014-09-16 21:59:46]

Patchset 2 (id:??) landed as
https://crrev.com/4c4c9c73968ec4c1c28c48559d392e2d2c42cc6e
Cr-Commit-Position: refs/heads/master@{#295153}