Issue 452923002: Remove external SkImageFilter cache, and rename UniqueIDCache -> Cache.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 452923002: Remove external SkImageFilter cache, and rename UniqueIDCache -> Cache. (Closed)

Created:
6 years, 4 months ago by Stephen White

Modified:
6 years, 4 months ago

Reviewers:
bsalomon

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

Remove external SkImageFilter cache, and rename UniqueIDCache -> Cache. There Can Only Be One.... Cache for SkImageFilter. R=bsalomon@google.com BUG=skia: Committed: https://skia.googlesource.com/skia/+/be129b26f13d575fd6b396c6ae759838ecc9bd1a

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+31 lines, -140 lines)			Patch
M	include/core/SkBitmapDevice.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	include/core/SkDevice.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	include/core/SkImageFilter.h	View	1 chunk	+7 lines, -19 lines	0 comments	Download
M	include/gpu/SkGpuDevice.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/core/SkBitmapDevice.cpp	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/core/SkCanvas.cpp	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/core/SkImageFilter.cpp	View	8 chunks	+13 lines, -110 lines	0 comments	Download
M	src/gpu/SkGpuDevice.cpp	View	3 chunks	+4 lines, -4 lines	0 comments	Download

Total messages: 5 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/senorblanco@chromium.org/452923002/1

6 years, 4 months ago (2014-08-08 14:07:46 UTC) #4

commit-bot: I haz the power

6 years, 4 months ago (2014-08-08 14:14:42 UTC) #5

Message was sent while issue was closed.

Change committed as be129b26f13d575fd6b396c6ae759838ecc9bd1a