Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(508)

Issue 452913002: First implementation of enhanced_bookmark_utils. (Closed)

Created:
6 years, 4 months ago by noyau (Ping after 24h)
Modified:
6 years, 4 months ago
Reviewers:
blundell
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

First implementation of enhanced_bookmark_utils. These utility functions are used on iOS and Android. BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288408

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+237 lines, -0 lines) Patch
M components/components_tests.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M components/enhanced_bookmarks.gypi View 1 chunk +3 lines, -0 lines 0 comments Download
A components/enhanced_bookmarks/enhanced_bookmark_utils.h View 1 chunk +49 lines, -0 lines 1 comment Download
A components/enhanced_bookmarks/enhanced_bookmark_utils.cc View 1 chunk +127 lines, -0 lines 0 comments Download
A components/enhanced_bookmarks/enhanced_bookmark_utils_unittest.cc View 1 chunk +57 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
noyau (Ping after 24h)
6 years, 4 months ago (2014-08-08 13:36:58 UTC) #1
blundell
lgtm https://codereview.chromium.org/452913002/diff/1/components/enhanced_bookmarks/enhanced_bookmark_utils.h File components/enhanced_bookmarks/enhanced_bookmark_utils.h (right): https://codereview.chromium.org/452913002/diff/1/components/enhanced_bookmarks/enhanced_bookmark_utils.h#newcode15 components/enhanced_bookmarks/enhanced_bookmark_utils.h:15: namespace enhanced_bookmark_utils { oops, I had missed that ...
6 years, 4 months ago (2014-08-08 13:39:09 UTC) #2
noyau (Ping after 24h)
The CQ bit was checked by noyau@chromium.org
6 years, 4 months ago (2014-08-08 14:10:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noyau@chromium.org/452913002/1
6 years, 4 months ago (2014-08-08 14:12:06 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_chromium_rel_swarming on tryserver.chromium.mac ...
6 years, 4 months ago (2014-08-08 18:33:29 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-08-08 19:06:22 UTC) #6
Message was sent while issue was closed.
Change committed as 288408

Powered by Google App Engine
This is Rietveld 408576698