Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2062)

Unified Diff: Tools/Scripts/webkitpy/layout_tests/port/factory.py

Issue 452893002: [Nit] Sorting run-webkit-tests options in alphabetical order. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Addressing Comments Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Tools/Scripts/webkitpy/layout_tests/port/factory.py
diff --git a/Tools/Scripts/webkitpy/layout_tests/port/factory.py b/Tools/Scripts/webkitpy/layout_tests/port/factory.py
index 8703ddf3d3e612488820f5b68293557da895d2c7..70769d432813a8f2f8244fb4bfdbbbda61ea3edb 100644
--- a/Tools/Scripts/webkitpy/layout_tests/port/factory.py
+++ b/Tools/Scripts/webkitpy/layout_tests/port/factory.py
@@ -37,26 +37,26 @@ from webkitpy.layout_tests.port import builders
def platform_options(use_globs=False):
return [
- optparse.make_option('--platform', action='store',
- help=('Glob-style list of platform/ports to use (e.g., "mac*")' if use_globs else 'Platform to use (e.g., "mac-lion")')),
+ optparse.make_option('--android', action='store_const', dest='platform',
+ const=('android*' if use_globs else 'android'),
+ help=('Alias for --platform=android*' if use_globs else 'Alias for --platform=android')),
# FIXME: Update run_webkit_tests.sh, any other callers to no longer pass --chromium, then remove this flag.
optparse.make_option('--chromium', action='store_const', dest='platform',
const=('chromium*' if use_globs else 'chromium'),
help=('Alias for --platform=chromium*' if use_globs else 'Alias for --platform=chromium')),
- optparse.make_option('--android', action='store_const', dest='platform',
- const=('android*' if use_globs else 'android'),
- help=('Alias for --platform=android*' if use_globs else 'Alias for --platform=android')),
+ optparse.make_option('--platform', action='store',
+ help=('Glob-style list of platform/ports to use (e.g., "mac*")' if use_globs else 'Platform to use (e.g., "mac-lion")')),
]
def configuration_options():
return [
- optparse.make_option("-t", "--target", dest="configuration",
- help="specify the target configuration to use (Debug/Release)"),
optparse.make_option('--debug', action='store_const', const='Debug', dest="configuration",
help='Set the configuration to Debug'),
+ optparse.make_option("-t", "--target", dest="configuration",
+ help="specify the target configuration to use (Debug/Release)"),
optparse.make_option('--release', action='store_const', const='Release', dest="configuration",
help='Set the configuration to Release'),
]
« no previous file with comments | « no previous file | Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698