Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Issue 452893002: [Nit] Sorting run-webkit-tests options in alphabetical order. (Closed)

Created:
6 years, 4 months ago by patro
Modified:
6 years, 3 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

[Nit] Sorting run-webkit-tests options in alphabetical order. run-webkit-tests --help prints a number of options which are unordered. This makes it difficult to locate an option as the options are considerable in number. Sorting them alphabetically eases the task of locating a particular option. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181402

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressing Comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+109 lines, -110 lines) Patch
M Tools/Scripts/webkitpy/layout_tests/port/factory.py View 1 chunk +7 lines, -7 lines 0 comments Download
M Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py View 1 4 chunks +98 lines, -99 lines 0 comments Download
M Tools/Scripts/webkitpy/layout_tests/views/printing.py View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (1 generated)
patro
Kindly Review, Thanks, Shyam Patro
6 years, 4 months ago (2014-08-08 12:54:48 UTC) #1
Dirk Pranke
This seems fine to me. If you were sorting alphabetically, I might be inclined to ...
6 years, 4 months ago (2014-08-08 20:15:24 UTC) #2
patro
https://codereview.chromium.org/452893002/diff/1/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py File Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py (right): https://codereview.chromium.org/452893002/diff/1/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py#newcode176 Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py:176: optparse.make_option("-p", "--pixel", "--pixel-tests", action="store_true", On 2014/08/08 20:15:24, Dirk Pranke ...
6 years, 4 months ago (2014-08-09 17:15:54 UTC) #3
patro
On 2014/08/09 17:15:54, patro wrote: > https://codereview.chromium.org/452893002/diff/1/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py > File Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py (right): > > https://codereview.chromium.org/452893002/diff/1/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py#newcode176 > ...
6 years, 4 months ago (2014-08-19 12:35:27 UTC) #4
Dirk Pranke
On 2014/08/19 12:35:27, patro wrote: > Friendly ping! eseidel: do you think we should keep ...
6 years, 4 months ago (2014-08-19 16:08:50 UTC) #5
patro
On 2014/08/19 16:08:50, Dirk Pranke wrote: > On 2014/08/19 12:35:27, patro wrote: > > Friendly ...
6 years, 3 months ago (2014-09-01 14:07:02 UTC) #6
Dirk Pranke
On 2014/09/01 14:07:02, patro wrote: > On 2014/08/19 16:08:50, Dirk Pranke wrote: > > On ...
6 years, 3 months ago (2014-09-03 20:42:16 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/behara.ms@samsung.com/452893002/20001
6 years, 3 months ago (2014-09-04 19:41:57 UTC) #9
commit-bot: I haz the power
6 years, 3 months ago (2014-09-04 21:53:04 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 181402

Powered by Google App Engine
This is Rietveld 408576698