Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(344)

Issue 452883002: Fix crash caused by Canvas2DLayerBridge::mailboxReleased (Closed)

Created:
6 years, 4 months ago by Hongbo Min
Modified:
6 years, 4 months ago
CC:
blink-reviews, jamesr, krit, jbroman, danakj, Rik, Stephen Chennney, pdr., rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Fix crash caused by Canvas2DLayerBridge::mailboxReleased In case of the resource is lost but context is not lost, the mailboxInfo will be removed from mailbox list, and so the reference to its parent Canvas2DLayerBridge will also be cleared. This fix is to return early to avoid crash by clearing the parent Canvas2DLayerBridge twice. BUG=401697 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179841

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M Source/platform/graphics/Canvas2DLayerBridge.cpp View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Hongbo Min
kbr@, junov@, please take a review. Thanks a lot!
6 years, 4 months ago (2014-08-08 11:24:11 UTC) #1
Justin Novosad
On 2014/08/08 11:24:11, Hongbo Min wrote: > kbr@, junov@, please take a review. Thanks a ...
6 years, 4 months ago (2014-08-08 13:03:35 UTC) #2
Justin Novosad
The CQ bit was checked by junov@chromium.org
6 years, 4 months ago (2014-08-08 13:44:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hongbo.min@intel.com/452883002/1
6 years, 4 months ago (2014-08-08 13:45:09 UTC) #4
commit-bot: I haz the power
Change committed as 179841
6 years, 4 months ago (2014-08-08 16:00:31 UTC) #5
Ken Russell (switch to Gerrit)
Is it possible to write a test for this? If so, please do.
6 years, 4 months ago (2014-08-08 17:44:10 UTC) #6
Hongbo Min
6 years, 4 months ago (2014-08-11 01:30:20 UTC) #7
Message was sent while issue was closed.
On 2014/08/08 17:44:10, Ken Russell wrote:
> Is it possible to write a test for this? If so, please do.

Yes, i think so, it needs more test cases for Canvas2DLayerBridge.

Powered by Google App Engine
This is Rietveld 408576698