Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(939)

Unified Diff: chrome/browser/apps/ephemeral_app_browsertest.cc

Issue 452853002: Disable ReplaceEphemeralAppWithInstalledApp on Windows due to flakiness. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/apps/ephemeral_app_browsertest.cc
diff --git a/chrome/browser/apps/ephemeral_app_browsertest.cc b/chrome/browser/apps/ephemeral_app_browsertest.cc
index 3f54c1adf10defd79eecdd7b8a8c75c960b7e11f..71a64e2dfaa4e6f26551db8a38cf849fb079ee2c 100644
--- a/chrome/browser/apps/ephemeral_app_browsertest.cc
+++ b/chrome/browser/apps/ephemeral_app_browsertest.cc
@@ -866,8 +866,16 @@ IN_PROC_BROWSER_TEST_F(EphemeralAppBrowserTest,
// permanently install an ephemeral app. However, there may be cases where an
// install occurs through the usual route of installing from the Web Store (due
// to race conditions). Ensure that the app is still installed correctly.
+#if defined(OS_WIN)
+// Disabled on Windows due to failures. See crbug.com/401028
+#define MAYBE_ReplaceEphemeralAppWithInstalledApp \
+ DISABLED_ReplaceEphemeralAppWithInstalledApp
+#else
+#define MAYBE_ReplaceEphemeralAppWithInstalledApp \
+ ReplaceEphemeralAppWithInstalledApp
+#endif
IN_PROC_BROWSER_TEST_F(EphemeralAppBrowserTest,
- ReplaceEphemeralAppWithInstalledApp) {
+ MAYBE_ReplaceEphemeralAppWithInstalledApp) {
InitSyncService();
const Extension* app = InstallAndLaunchEphemeralApp(kNotificationsTestApp);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698