Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Unified Diff: trunk/src/chrome/browser/local_discovery/service_discovery_shared_client.cc

Issue 452843002: Revert 270745 "Enable ServiceDiscoveryClientMdns." to fix crash. (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: trunk/src/chrome/browser/local_discovery/service_discovery_shared_client.cc
===================================================================
--- trunk/src/chrome/browser/local_discovery/service_discovery_shared_client.cc (revision 288262)
+++ trunk/src/chrome/browser/local_discovery/service_discovery_shared_client.cc (working copy)
@@ -20,7 +20,6 @@
#endif
#if defined(ENABLE_MDNS)
-#include "chrome/browser/local_discovery/service_discovery_client_mdns.h"
#include "chrome/browser/local_discovery/service_discovery_client_utility.h"
#endif // ENABLE_MDNS
@@ -27,9 +26,6 @@
namespace {
#if defined(OS_WIN)
-
-bool g_is_firewall_ready = false;
-
void ReportFirewallStats() {
base::FilePath exe_path;
if (!PathService::Get(base::FILE_EXE, &exe_path))
@@ -40,9 +36,9 @@
exe_path);
if (!manager)
return;
- g_is_firewall_ready = manager->CanUseLocalPorts();
+ bool is_ready = manager->CanUseLocalPorts();
UMA_HISTOGRAM_TIMES("LocalDiscovery.FirewallAccessTime", timer.Elapsed());
- UMA_HISTOGRAM_BOOLEAN("LocalDiscovery.IsFirewallReady", g_is_firewall_ready);
+ UMA_HISTOGRAM_BOOLEAN("LocalDiscovery.IsFirewallReady", is_ready);
}
#endif // OS_WIN
@@ -84,13 +80,11 @@
static bool reported =
BrowserThread::PostTask(BrowserThread::FILE, FROM_HERE,
base::Bind(&ReportFirewallStats));
+#endif // OS_WIN
+
// TODO(vitalybuka): Switch to |ServiceDiscoveryClientMdns| after we find what
// to do with firewall for user-level installs. crbug.com/366408
- if (!g_is_firewall_ready)
- return new ServiceDiscoveryClientUtility();
-#endif // OS_WIN
-
- return new ServiceDiscoveryClientMdns();
+ return new ServiceDiscoveryClientUtility();
#endif // OS_MACOSX
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698