Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 452813002: Mark LayoutTests fast/js/kde/StringObject.html as NeedsRebaseline. (Closed)

Created:
6 years, 4 months ago by Yang
Modified:
6 years, 4 months ago
Reviewers:
Michael Achenbach
CC:
blink-reviews
Project:
blink
Visibility:
Public.

Description

Mark LayoutTests fast/js/kde/StringObject.html as NeedsRebaseline. R=machenbach@chromium.org BUG=401408 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179824

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M LayoutTests/TestExpectations View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
Yang
6 years, 4 months ago (2014-08-08 07:41:06 UTC) #1
Michael Achenbach
LGTM
6 years, 4 months ago (2014-08-08 08:03:06 UTC) #2
Michael Achenbach
The CQ bit was checked by machenbach@chromium.org
6 years, 4 months ago (2014-08-08 08:03:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yangguo@chromium.org/452813002/1
6 years, 4 months ago (2014-08-08 08:03:41 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-08 10:00:18 UTC) #5
commit-bot: I haz the power
Failed to apply patch for LayoutTests/TestExpectations: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 4 months ago (2014-08-08 10:00:19 UTC) #6
Yang
The CQ bit was checked by yangguo@chromium.org
6 years, 4 months ago (2014-08-08 10:48:42 UTC) #7
Yang
Rebased.
6 years, 4 months ago (2014-08-08 10:48:55 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yangguo@chromium.org/452813002/20001
6 years, 4 months ago (2014-08-08 10:49:56 UTC) #9
commit-bot: I haz the power
6 years, 4 months ago (2014-08-08 12:20:04 UTC) #10
Message was sent while issue was closed.
Change committed as 179824

Powered by Google App Engine
This is Rietveld 408576698