Source/bindings/scripts/v8_attributes.py - Issue 452743003: Rename V8X::fooMethodImplementedInPrivateScript to V8X::PrivateScript::fooMethod

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/scripts/v8_attributes.py

Issue 452743003: Rename V8X::fooMethodImplementedInPrivateScript to V8X::PrivateScript::fooMethod (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/scripts/v8_attributes.py

diff --git a/Source/bindings/scripts/v8_attributes.py b/Source/bindings/scripts/v8_attributes.py

index 3f3b3f649d2389ced02c1b1a389dadd7adada875..670b5c1e434e7772040dc86938c6fec3fa4a1f5f 100644

--- a/Source/bindings/scripts/v8_attributes.py

+++ b/Source/bindings/scripts/v8_attributes.py

@@ -253,7 +253,7 @@ def getter_base_name(interface, attribute, arguments):

extended_attributes = attribute.extended_attributes

if 'ImplementedInPrivateScript' in extended_attributes:

- return '%sAttributeGetterImplementedInPrivateScript' % uncapitalize(cpp_name(attribute))

+ return '%sAttributeGetter' % uncapitalize(cpp_name(attribute))

if 'Reflect' not in extended_attributes:

return uncapitalize(cpp_name(attribute))

@@ -398,7 +398,7 @@ CONTENT_ATTRIBUTE_SETTER_NAMES = {

def setter_base_name(interface, attribute, arguments):

if 'ImplementedInPrivateScript' in attribute.extended_attributes:

- return '%sAttributeSetterImplementedInPrivateScript' % uncapitalize(cpp_name(attribute))

+ return '%sAttributeSetter' % uncapitalize(cpp_name(attribute))

if 'Reflect' not in attribute.extended_attributes:

return 'set%s' % capitalize(cpp_name(attribute))

« no previous file with comments | « no previous file | Source/bindings/scripts/v8_interface.py » ('j') | Source/bindings/scripts/v8_interface.py » ('J')