Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Unified Diff: Source/bindings/templates/interface.h

Issue 452743003: Rename V8X::fooMethodImplementedInPrivateScript to V8X::PrivateScript::fooMethod (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/templates/interface.h
diff --git a/Source/bindings/templates/interface.h b/Source/bindings/templates/interface.h
index 17b1f971efde2c8dc08e4a7faffa96c6764b23e9..e75d64dcb9b97b1fcbd0bd7c0bbcf1d454a1155d 100644
--- a/Source/bindings/templates/interface.h
+++ b/Source/bindings/templates/interface.h
@@ -27,6 +27,19 @@ public:
{% endif %}
class {{v8_class}} {
public:
+ class PrivateScript {
+ public:
+ {% for method in methods if method.is_implemented_in_private_script %}
+ static bool {{method.name}}Method({{method.argument_declarations_for_private_script | join(', ')}});
+ {% endfor %}
+ {% for attribute in attributes if attribute.is_implemented_in_private_script %}
+ static bool {{attribute.name}}AttributeGetter(LocalFrame* frame, {{cpp_class}}* holderImpl, {{attribute.cpp_type}}* result);
+ {% if not attribute.is_read_only or attribute.put_forwards %}
Jens Widell 2014/08/08 07:08:25 Would [PutForwards] work on an attribute implement
haraken 2014/08/08 07:25:03 No, so removed :)
+ static bool {{attribute.name}}AttributeSetter(LocalFrame* frame, {{cpp_class}}* holderImpl, {{attribute.argument_cpp_type}} cppValue);
+ {% endif %}
+ {% endfor %}
+ };
+
static bool hasInstance(v8::Handle<v8::Value>, v8::Isolate*);
static v8::Handle<v8::Object> findInstanceInPrototypeChain(v8::Handle<v8::Value>, v8::Isolate*);
static v8::Handle<v8::FunctionTemplate> domTemplate(v8::Isolate*);
@@ -55,9 +68,6 @@ public:
static void {{method.name}}MethodCustom(const v8::FunctionCallbackInfo<v8::Value>&);
{% endfilter %}
{% endif %}
- {% if method.is_implemented_in_private_script %}
- static bool {{method.name}}MethodImplementedInPrivateScript({{method.argument_declarations_for_private_script | join(', ')}});
- {% endif %}
{% endfor %}
{% if constructors or has_custom_constructor or has_event_constructor %}
static void constructorCallback(const v8::FunctionCallbackInfo<v8::Value>&);
@@ -76,12 +86,6 @@ public:
static void {{attribute.name}}AttributeSetterCustom(v8::Local<v8::Value>, const v8::PropertyCallbackInfo<void>&);
{% endfilter %}
{% endif %}
- {% if attribute.is_implemented_in_private_script %}
- static bool {{attribute.name}}AttributeGetterImplementedInPrivateScript(LocalFrame* frame, {{cpp_class}}* holderImpl, {{attribute.cpp_type}}* result);
- {% if not attribute.is_read_only or attribute.put_forwards %}
- static bool {{attribute.name}}AttributeSetterImplementedInPrivateScript(LocalFrame* frame, {{cpp_class}}* holderImpl, {{attribute.argument_cpp_type}} cppValue);
- {% endif %}
- {% endif %}
{% endfor %}
{# Custom special operations #}
{% if indexed_property_getter and indexed_property_getter.is_custom %}

Powered by Google App Engine
This is Rietveld 408576698