Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(551)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 452743003: Rename V8X::fooMethodImplementedInPrivateScript to V8X::PrivateScript::fooMethod (Closed)

Created:
6 years, 4 months ago by haraken
Modified:
6 years, 4 months ago
Reviewers:
vivekg, Jens Widell, bashi
CC:
blink-reviews, blink-reviews-bindings_chromium.org, arv+blink, abarth-chromium
Project:
blink
Visibility:
Public.

Description

Rename V8X::fooMethodImplementedInPrivateScript to V8X::PrivateScript::fooMethod It's messy to scatter a lot of xxxImplementedInPrivateScript methods in V8 binding classes. We should create an inner class (V8X::PrivateScript) and put the methods in the inner class. BUG=341031 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179821

Patch Set 1 #

Total comments: 5

Patch Set 2 : #

Total comments: 4

Patch Set 3 : #

Total comments: 1

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -74 lines) Patch
M Source/bindings/scripts/v8_attributes.py View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/scripts/v8_interface.py View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M Source/bindings/scripts/v8_methods.py View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/scripts/v8_utilities.py View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/templates/attributes.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/templates/interface.h View 1 2 3 4 3 chunks +15 lines, -9 lines 0 comments Download
M Source/bindings/templates/methods.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestInterface.h View 1 2 3 4 5 2 chunks +7 lines, -3 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterface.cpp View 1 2 3 4 5 6 chunks +6 lines, -6 lines 0 comments Download
M Source/bindings/tests/results/V8TestObject.h View 3 chunks +20 lines, -16 lines 0 comments Download
M Source/bindings/tests/results/V8TestObject.cpp View 29 chunks +29 lines, -29 lines 0 comments Download
M Source/core/testing/PrivateScriptTestTest.cpp View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 24 (0 generated)
haraken
bashi-san@ or jl@ or vivekg@: PTAL
6 years, 4 months ago (2014-08-08 06:46:59 UTC) #1
bashi
LGTM https://codereview.chromium.org/452743003/diff/1/Source/bindings/templates/interface.h File Source/bindings/templates/interface.h (right): https://codereview.chromium.org/452743003/diff/1/Source/bindings/templates/interface.h#newcode30 Source/bindings/templates/interface.h:30: class PrivateScript { nit: We might want to ...
6 years, 4 months ago (2014-08-08 06:58:52 UTC) #2
haraken
Thanks for review! https://codereview.chromium.org/452743003/diff/1/Source/bindings/templates/interface.h File Source/bindings/templates/interface.h (right): https://codereview.chromium.org/452743003/diff/1/Source/bindings/templates/interface.h#newcode32 Source/bindings/templates/interface.h:32: {% for method in methods %} ...
6 years, 4 months ago (2014-08-08 07:01:48 UTC) #3
haraken
The CQ bit was checked by haraken@chromium.org
6 years, 4 months ago (2014-08-08 07:02:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haraken@chromium.org/452743003/20001
6 years, 4 months ago (2014-08-08 07:03:16 UTC) #5
Jens Widell
LGTM https://codereview.chromium.org/452743003/diff/20001/Source/bindings/templates/interface.h File Source/bindings/templates/interface.h (right): https://codereview.chromium.org/452743003/diff/20001/Source/bindings/templates/interface.h#newcode37 Source/bindings/templates/interface.h:37: {% if not attribute.is_read_only or attribute.put_forwards %} Would ...
6 years, 4 months ago (2014-08-08 07:08:25 UTC) #6
vivekg
awesome change, thank you! lgtm
6 years, 4 months ago (2014-08-08 07:11:41 UTC) #7
vivekg
https://codereview.chromium.org/452743003/diff/20001/Source/bindings/tests/results/V8TestInterfaceConstructor2.h File Source/bindings/tests/results/V8TestInterfaceConstructor2.h (right): https://codereview.chromium.org/452743003/diff/20001/Source/bindings/tests/results/V8TestInterfaceConstructor2.h#newcode21 Source/bindings/tests/results/V8TestInterfaceConstructor2.h:21: public: nit: Can we drop 'public' keyword here?
6 years, 4 months ago (2014-08-08 07:13:04 UTC) #8
haraken
The CQ bit was unchecked by haraken@chromium.org
6 years, 4 months ago (2014-08-08 07:16:03 UTC) #9
haraken
https://codereview.chromium.org/452743003/diff/20001/Source/bindings/templates/interface.h File Source/bindings/templates/interface.h (right): https://codereview.chromium.org/452743003/diff/20001/Source/bindings/templates/interface.h#newcode37 Source/bindings/templates/interface.h:37: {% if not attribute.is_read_only or attribute.put_forwards %} On 2014/08/08 ...
6 years, 4 months ago (2014-08-08 07:25:03 UTC) #10
haraken
The CQ bit was checked by haraken@chromium.org
6 years, 4 months ago (2014-08-08 07:25:09 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haraken@chromium.org/452743003/40001
6 years, 4 months ago (2014-08-08 07:25:17 UTC) #12
Jens Widell
https://codereview.chromium.org/452743003/diff/40001/Source/bindings/scripts/v8_interface.py File Source/bindings/scripts/v8_interface.py (right): https://codereview.chromium.org/452743003/diff/40001/Source/bindings/scripts/v8_interface.py#newcode315 Source/bindings/scripts/v8_interface.py:315: 'has_private_script': any(attribute['is_implemented_in_private_script'] for attribute in attributes) or This isn't ...
6 years, 4 months ago (2014-08-08 07:39:29 UTC) #13
haraken
The CQ bit was unchecked by haraken@chromium.org
6 years, 4 months ago (2014-08-08 07:45:42 UTC) #14
haraken
On 2014/08/08 07:39:29, Jens Lindström wrote: > https://codereview.chromium.org/452743003/diff/40001/Source/bindings/scripts/v8_interface.py > File Source/bindings/scripts/v8_interface.py (right): > > https://codereview.chromium.org/452743003/diff/40001/Source/bindings/scripts/v8_interface.py#newcode315 ...
6 years, 4 months ago (2014-08-08 07:48:47 UTC) #15
Jens Widell
On 2014/08/08 07:48:47, haraken wrote: > On 2014/08/08 07:39:29, Jens Lindström wrote: > > > ...
6 years, 4 months ago (2014-08-08 07:53:24 UTC) #16
haraken
The CQ bit was checked by haraken@chromium.org
6 years, 4 months ago (2014-08-08 07:54:06 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haraken@chromium.org/452743003/70001
6 years, 4 months ago (2014-08-08 07:54:24 UTC) #18
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_blink_compile_dbg on tryserver.blink ...
6 years, 4 months ago (2014-08-08 08:49:39 UTC) #19
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-08 09:31:12 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/android_chromium_gn_compile_rel/builds/6600) linux_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/19710)
6 years, 4 months ago (2014-08-08 09:31:15 UTC) #21
haraken
The CQ bit was checked by haraken@chromium.org
6 years, 4 months ago (2014-08-08 09:46:01 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haraken@chromium.org/452743003/90001
6 years, 4 months ago (2014-08-08 09:47:09 UTC) #23
commit-bot: I haz the power
6 years, 4 months ago (2014-08-08 11:32:27 UTC) #24
Message was sent while issue was closed. 
Change committed as 179821

Powered by Google App Engine
This is Rietveld 408576698