Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(439)

Issue 452723002: Oilpan: blink_heap_unittests: Test case have memory leak checked by Lsan (Closed)

Created:
6 years, 4 months ago by Daniel Chow
Modified:
6 years, 4 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Oilpan: blink_heap_unittests: Test case have memory leak checked by Lsan 1. For case TraceIfNeeded, modify TraceIfNeededTester to inherit from GarbageCollectedFinalized and at the end of test case TraceIfNeeded trigger a GC. After GC, the destructor of TraceIfNeededTester will dereference the RefPtr<OffHeapInt> instance, stop the leak. 2. For case MapWithCustomWeaknessHandling and MapWithCustomWeaknessHandling2, need clear the Persistent handle and trigger a GC at the end of test case. R=ager@chromium.org, oilpan-reviews@chromium.org BUG=401018 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179938

Patch Set 1 #

Total comments: 3

Patch Set 2 : Trigger a GC before HeapTest main() exits #

Total comments: 3

Patch Set 3 : change collectGarbage(...) to collectAllGarbage() in HeapTest main() #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M Source/platform/heap/HeapTest.cpp View 1 1 chunk +2 lines, -1 line 0 comments Download
M Source/platform/heap/RunAllTests.cpp View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 19 (0 generated)
Daniel Chow
Please Take A Look
6 years, 4 months ago (2014-08-11 01:53:36 UTC) #1
haraken
https://codereview.chromium.org/452723002/diff/1/Source/platform/heap/HeapTest.cpp File Source/platform/heap/HeapTest.cpp (right): https://codereview.chromium.org/452723002/diff/1/Source/platform/heap/HeapTest.cpp#newcode4157 Source/platform/heap/HeapTest.cpp:4157: livingInt.clear(); Hmm, I don't fully understand why we need ...
6 years, 4 months ago (2014-08-11 02:00:07 UTC) #2
haraken
https://codereview.chromium.org/452723002/diff/1/Source/platform/heap/HeapTest.cpp File Source/platform/heap/HeapTest.cpp (right): https://codereview.chromium.org/452723002/diff/1/Source/platform/heap/HeapTest.cpp#newcode4157 Source/platform/heap/HeapTest.cpp:4157: livingInt.clear(); Hmm, I don't fully understand why we need ...
6 years, 4 months ago (2014-08-11 02:00:08 UTC) #3
Daniel Chow
https://codereview.chromium.org/452723002/diff/1/Source/platform/heap/HeapTest.cpp File Source/platform/heap/HeapTest.cpp (right): https://codereview.chromium.org/452723002/diff/1/Source/platform/heap/HeapTest.cpp#newcode4157 Source/platform/heap/HeapTest.cpp:4157: livingInt.clear(); it's a good idea, I will make a ...
6 years, 4 months ago (2014-08-11 02:44:21 UTC) #4
Daniel Chow
Please Take Another Look.
6 years, 4 months ago (2014-08-11 06:11:01 UTC) #5
haraken
LGTM https://codereview.chromium.org/452723002/diff/20001/Source/platform/heap/RunAllTests.cpp File Source/platform/heap/RunAllTests.cpp (right): https://codereview.chromium.org/452723002/diff/20001/Source/platform/heap/RunAllTests.cpp#newcode61 Source/platform/heap/RunAllTests.cpp:61: blink::Heap::collectGarbage(blink::ThreadState::NoHeapPointersOnStack); I'd prefer blink::Heap::collectAllGarbage(), (which calls Heap::collectGarbage() multiple ...
6 years, 4 months ago (2014-08-11 06:12:39 UTC) #6
Daniel Chow
https://codereview.chromium.org/452723002/diff/20001/Source/platform/heap/RunAllTests.cpp File Source/platform/heap/RunAllTests.cpp (right): https://codereview.chromium.org/452723002/diff/20001/Source/platform/heap/RunAllTests.cpp#newcode61 Source/platform/heap/RunAllTests.cpp:61: blink::Heap::collectGarbage(blink::ThreadState::NoHeapPointersOnStack); On 2014/08/11 06:12:39, haraken wrote: > > I'd ...
6 years, 4 months ago (2014-08-11 06:32:25 UTC) #7
haraken
On 2014/08/11 06:32:25, Daniel Chow wrote: > https://codereview.chromium.org/452723002/diff/20001/Source/platform/heap/RunAllTests.cpp > File Source/platform/heap/RunAllTests.cpp (right): > > https://codereview.chromium.org/452723002/diff/20001/Source/platform/heap/RunAllTests.cpp#newcode61 ...
6 years, 4 months ago (2014-08-11 06:34:29 UTC) #8
Daniel Chow
On 2014/08/11 06:34:29, haraken wrote: > On 2014/08/11 06:32:25, Daniel Chow wrote: > > > ...
6 years, 4 months ago (2014-08-11 07:09:05 UTC) #9
haraken
On 2014/08/11 07:09:05, Daniel Chow wrote: > On 2014/08/11 06:34:29, haraken wrote: > > On ...
6 years, 4 months ago (2014-08-11 07:12:56 UTC) #10
Daniel Chow
On 2014/08/11 07:12:56, haraken wrote: > On 2014/08/11 07:09:05, Daniel Chow wrote: > > On ...
6 years, 4 months ago (2014-08-11 07:37:00 UTC) #11
haraken
On 2014/08/11 07:37:00, Daniel Chow wrote: > On 2014/08/11 07:12:56, haraken wrote: > > On ...
6 years, 4 months ago (2014-08-11 07:43:07 UTC) #12
zerny-chromium
lgtm https://codereview.chromium.org/452723002/diff/20001/Source/platform/heap/HeapTest.cpp File Source/platform/heap/HeapTest.cpp (right): https://codereview.chromium.org/452723002/diff/20001/Source/platform/heap/HeapTest.cpp#newcode4978 Source/platform/heap/HeapTest.cpp:4978: class TraceIfNeededTester : public GarbageCollectedFinalized<TraceIfNeededTester<T> > { Thanks! ...
6 years, 4 months ago (2014-08-11 08:24:00 UTC) #13
Daniel Chow
Please Take Another Look: I have changed collectGarbage(...) to collectAllGarbage() in HeapTest main()
6 years, 4 months ago (2014-08-11 09:38:52 UTC) #14
haraken
Still LGTM
6 years, 4 months ago (2014-08-11 09:42:47 UTC) #15
haraken
The CQ bit was checked by haraken@chromium.org
6 years, 4 months ago (2014-08-11 09:42:51 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zhishun.zhou@samsung.com/452723002/40001
6 years, 4 months ago (2014-08-11 09:43:53 UTC) #17
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_rel on tryserver.blink ...
6 years, 4 months ago (2014-08-11 11:14:44 UTC) #18
commit-bot: I haz the power
6 years, 4 months ago (2014-08-11 11:39:12 UTC) #19
Message was sent while issue was closed.
Change committed as 179938

Powered by Google App Engine
This is Rietveld 408576698