Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 452673002: Don't leave a RenderFrameProxyHost for the current RenderFrameHost. (Closed)

Created:
6 years, 4 months ago by Charlie Reis
Modified:
6 years, 4 months ago
Reviewers:
ncarter (slow)
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Don't leave a RenderFrameProxyHost for the current RenderFrameHost. This could happen in cases where we initiate a transfer but end up navigating in the original SiteInstance. BUG=402018 TEST=No proxy host for the current RFH after navigating an about:blank tab. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288406

Patch Set 1 : Original #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -11 lines) Patch
M content/browser/frame_host/frame_tree_browsertest.cc View 2 chunks +13 lines, -5 lines 1 comment Download
M content/browser/frame_host/render_frame_host_manager.h View 1 chunk +4 lines, -0 lines 0 comments Download
M content/browser/frame_host/render_frame_host_manager.cc View 3 chunks +18 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Charlie Reis
Nick, can you take a look? I can have Nasko look on Monday if you're ...
6 years, 4 months ago (2014-08-08 17:19:39 UTC) #1
ncarter (slow)
lgtm
6 years, 4 months ago (2014-08-08 17:52:17 UTC) #2
ncarter (slow)
The CQ bit was checked by nick@chromium.org
6 years, 4 months ago (2014-08-08 17:53:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/creis@chromium.org/452673002/20001
6 years, 4 months ago (2014-08-08 17:54:10 UTC) #4
commit-bot: I haz the power
6 years, 4 months ago (2014-08-08 18:56:22 UTC) #5
Message was sent while issue was closed.
Change committed as 288406

Powered by Google App Engine
This is Rietveld 408576698