Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Issue 452633002: Fix iOS build by centralizing --writePath. (Closed)

Created:
6 years, 4 months ago by mtklein_C
Modified:
6 years, 4 months ago
Reviewers:
mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Fix iOS build by centralizing --writePath. CQ_EXTRA_TRYBOTS=tryserver.skia:Build-Mac10.7-Clang-Arm7-Debug-iOS-Trybot BUG=skia: Committed: https://skia.googlesource.com/skia/+/b511042bb07a6a289b0d1146cb57f6e8b80580d6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M bench/nanobench.cpp View 2 chunks +1 line, -3 lines 0 comments Download
M dm/DMWriteTask.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M tools/flags/SkCommonFlags.h View 1 chunk +1 line, -0 lines 0 comments Download
M tools/flags/SkCommonFlags.cpp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
mtklein
lgtm
6 years, 4 months ago (2014-08-07 21:59:53 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/452633002/1
6 years, 4 months ago (2014-08-07 22:01:01 UTC) #2
commit-bot: I haz the power
6 years, 4 months ago (2014-08-07 22:20:41 UTC) #3
Message was sent while issue was closed.
Change committed as b511042bb07a6a289b0d1146cb57f6e8b80580d6

Powered by Google App Engine
This is Rietveld 408576698