Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Issue 452603002: [GCM] Adding checkin server scope in GCM Account Tracker (Closed)

Created:
6 years, 4 months ago by fgorski
Modified:
6 years, 4 months ago
Reviewers:
Nicolas Zea
CC:
chromium-reviews, zea+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

[GCM] Adding checkin server scope in GCM Account Tracker * Android Checkin server started handling OAuth2 tokens for checkin very recently and is using the added scope to do it. BUG=374969 R=zea@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288262

Patch Set 1 #

Patch Set 2 : Removing trailing slash from the scope #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M chrome/browser/services/gcm/gcm_account_tracker.cc View 1 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
fgorski
PTAL. I spoke with Michael and Android introduced another OAuth2 scope for the checkin, I ...
6 years, 4 months ago (2014-08-07 21:04:17 UTC) #1
Nicolas Zea
lgtm
6 years, 4 months ago (2014-08-07 21:18:20 UTC) #2
fgorski
The CQ bit was checked by fgorski@chromium.org
6 years, 4 months ago (2014-08-07 21:18:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fgorski@chromium.org/452603002/20001
6 years, 4 months ago (2014-08-07 21:41:22 UTC) #4
commit-bot: I haz the power
6 years, 4 months ago (2014-08-08 08:35:56 UTC) #5
Message was sent while issue was closed.
Change committed as 288262

Powered by Google App Engine
This is Rietveld 408576698