Issue 452533002: Revert of add isRect() check to AAClip, to detect if a soft-clip is really just an irect

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 452533002: Revert of add isRect() check to AAClip, to detect if a soft-clip is really just an irect (Closed)

Created:
6 years, 4 months ago by reed1

Modified:
6 years, 4 months ago

Reviewers:
humper, bsalomon

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

Revert of add isRect() check to AAClip, to detect if a soft-clip is really just an irect (https://codereview.chromium.org/445233006/) Reason for revert: new code asserts on some pictures Original issue's description: > add isRect() check to AAClip, to detect if a soft-clip is really just an irect > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/592cb8d552556b1e922887d506d00b64bc5d0547 TBR=bsalomon@google.com,humper@google.com NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/0aeea6d344f12e35e29a79f4bbc48af88f913204

Created: 6 years, 4 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+4 lines, -73 lines)			Patch
M	src/core/SkAAClip.h	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	src/core/SkAAClip.cpp	View	1 chunk	+0 lines, -29 lines	0 comments	Download
M	src/core/SkRasterClip.h	View	1 chunk	+2 lines, -10 lines	0 comments	Download
M	src/core/SkRasterClip.cpp	View	1 chunk	+1 line, -4 lines	0 comments	Download
M	tests/AAClipTest.cpp	View	2 chunks	+1 line, -26 lines	0 comments	Download

Total messages: 3 (0 generated)

reed1

Created Revert of add isRect() check to AAClip, to detect if a soft-clip is really ...

6 years, 4 months ago (2014-08-07 18:16:44 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/reed@google.com/452533002/1

6 years, 4 months ago (2014-08-07 18:18:35 UTC) #2

commit-bot: I haz the power

6 years, 4 months ago (2014-08-07 18:19:23 UTC) #3

Message was sent while issue was closed.

Change committed as 0aeea6d344f12e35e29a79f4bbc48af88f913204