Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 45253002: Do not use set process names in the Activity Monitor, using Process Manager functions in the proces… (Closed)

Created:
7 years, 1 month ago by Avi (use Gerrit)
Modified:
7 years, 1 month ago
Reviewers:
Mark Mentovai, Nico
CC:
chromium-reviews, stuartmorgan+watch_chromium.org, erikwright+watch_chromium.org, jam
Visibility:
Public.

Description

Do not set process names in the Activity Monitor. This involves Process Manager functions, which in 10.9 cause a WindowServer checkin, which causes "not responding" notifications on any child process that doesn't pump events (which is everything but the renderers). BUG=304860 TEST=Plugin process on Mavericks shouldn't have an app icon to its left, shouldn't be "not responding" R=mark@chromium.org, thakis@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=231108

Patch Set 1 #

Total comments: 5

Patch Set 2 : grd fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -185 lines) Patch
M base/mac/mac_util.h View 1 chunk +0 lines, -3 lines 0 comments Download
M base/mac/mac_util.mm View 1 chunk +0 lines, -90 lines 0 comments Download
M chrome/app/chrome_main_delegate.cc View 2 chunks +0 lines, -32 lines 0 comments Download
M chrome/app/chromium_strings.grd View 1 1 chunk +0 lines, -17 lines 0 comments Download
M chrome/app/google_chrome_strings.grd View 1 1 chunk +0 lines, -17 lines 0 comments Download
M chrome/plugin/chrome_content_plugin_client.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/plugin/chrome_content_plugin_client.cc View 2 chunks +0 lines, -25 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Avi (use Gerrit)
Mark for base, Nico for rest
7 years, 1 month ago (2013-10-25 19:46:08 UTC) #1
Nico
lgtm lebtm if the CL description said why this is happening (but it has a ...
7 years, 1 month ago (2013-10-25 19:52:40 UTC) #2
Mark Mentovai
https://codereview.chromium.org/45253002/diff/1/base/mac/mac_util.mm File base/mac/mac_util.mm (left): https://codereview.chromium.org/45253002/diff/1/base/mac/mac_util.mm#oldcode316 base/mac/mac_util.mm:316: // comment for 10.8. OK, so we never did ...
7 years, 1 month ago (2013-10-25 19:59:11 UTC) #3
Avi (use Gerrit)
ok https://codereview.chromium.org/45253002/diff/1/base/mac/mac_util.mm File base/mac/mac_util.mm (left): https://codereview.chromium.org/45253002/diff/1/base/mac/mac_util.mm#oldcode316 base/mac/mac_util.mm:316: // comment for 10.8. On 2013/10/25 19:59:11, Mark ...
7 years, 1 month ago (2013-10-25 20:03:10 UTC) #4
Mark Mentovai
LGTM
7 years, 1 month ago (2013-10-25 20:38:12 UTC) #5
Avi (use Gerrit)
7 years, 1 month ago (2013-10-25 20:47:08 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 manually as r231108 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698