Limit the number of archived results in Layout Tests.

Limit the number of archived results in Layout Tests.

There has to be a limit on the number of results that can be archived because they take up considerable amount of disk space.

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179792

[patro, 2014-08-07 14:34:38]

Kindly Review,

Thanks,
Shyam Patro

[Dirk Pranke, 2014-08-07 15:56:51]

lgtm w/ a couple of minor comments.

https://codereview.chromium.org/452493002/diff/1/Tools/Scripts/webkitpy/layou...
File Tools/Scripts/webkitpy/layout_tests/controllers/manager.py (right):

https://codereview.chromium.org/452493002/diff/1/Tools/Scripts/webkitpy/layou...
Tools/Scripts/webkitpy/layout_tests/controllers/manager.py:183:
self._filesystem.rmtree(results_directories[index])
You can rewrite lines 178-183 as:

self._printer.write_update(...)
for dir in results_directories[:-self.ARCHIVED_RESULTS_LIMIT]:
    self._filesystem.rmtree(dir)

I'd probably also pull the repeated join on lines 175-176 out into a temp
variable.

[patro, 2014-08-08 05:24:01]

PTAL

Thanks,
Shyam

https://codereview.chromium.org/452493002/diff/1/Tools/Scripts/webkitpy/layou...
File Tools/Scripts/webkitpy/layout_tests/controllers/manager.py (right):

https://codereview.chromium.org/452493002/diff/1/Tools/Scripts/webkitpy/layou...
Tools/Scripts/webkitpy/layout_tests/controllers/manager.py:183:
self._filesystem.rmtree(results_directories[index])
On 2014/08/07 15:56:51, Dirk Pranke wrote:
> You can rewrite lines 178-183 as:
> 
> self._printer.write_update(...)
> for dir in results_directories[:-self.ARCHIVED_RESULTS_LIMIT]:
>     self._filesystem.rmtree(dir)
> 
> I'd probably also pull the repeated join on lines 175-176 out into a temp
> variable.
> 

Done.

[patro, 2014-08-08 05:24:32]

The CQ bit was checked by behara.ms@samsung.com

[commit-bot: I haz the power, 2014-08-08 05:24:53]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/behara.ms@samsung.com/452493002/20001

[commit-bot: I haz the power, 2014-08-08 06:48:05]

Change committed as 179792