Cleanup in CodegenJavaVisitor.javaType(...), no functional change.

pkg/analysis_server/tool/spec/codegen_java.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /**
  * Tools for Java code generation.
  */
 library CodegenJava;
 
 import 'dart:io';
@@ skipping 10 matching lines @@
 
   /**
    * Variable names which must be changed in order to avoid conflict with
    * reserved words in Java.
    */
   static const Map<String, String> _variableRenames = const {
     'default': 'defaultSdk'
   };
 
   /**
+   * Type references in the spec that are named something else in Java.
+   */
+  static const Map<String, String> _typeRenames = const {
+    'bool': 'boolean',
+    'FilePath': 'String',
+    'DebugContextId': 'String',
+    'object': 'Object',
+  };
+
+  /**
    * Visitor used to produce doc comments.
    */
   final ToHtmlVisitor toHtmlVisitor;
 
   CodegenJavaVisitor(Api api)
       : super(api),
         toHtmlVisitor = new ToHtmlVisitor(api);
 
   /**
    * Create a private method, using [callback] to create its contents.
@@ skipping 34 matching lines @@
       _state = oldState;
     }
   }
 
   /**
    * Convert the given [TypeDecl] to a Java type.
    */
   String javaType(TypeDecl type) {
     if (type is TypeReference) {
       TypeReference resolvedType = resolveTypeReferenceChain(type);
-      switch (resolvedType.typeName) {
-        // TODO(jwren) make this into a type type renames map, like _variableRenames
-        case 'bool':
-          return 'boolean';
-        case 'FilePath':
-          return 'String';
-        case 'DebugContextId':
-          return 'String';
-        case 'object':
-          return 'Object';
-        default:
-          return resolvedType.typeName;
+      String typeName = resolvedType.typeName;
+      if (_typeRenames.containsKey(typeName)) {
+        return _typeRenames[typeName];
+      } else {
+        return typeName;
       }
     } else if (type is TypeList) {
       return 'List<${javaType(type.itemType)}>';
     } else if (type is TypeMap) {
       return 'Map<${javaType(type.keyType)}, ${javaType(type.valueType)}>';
     } else {
       throw new Exception("Can't make type buildable");
     }
   }
 
@@ skipping 42 matching lines @@
 }
 
 /**
  * Use [visitor] to create Java code and output it to [path].
  */
 void createJavaCode(String path, CodegenJavaVisitor visitor) {
   String code = visitor.collectCode(visitor.visitApi);
   File outputFile = new File(path);
   outputFile.writeAsStringSync(code);
 }