Source/core/rendering/RenderObject.cpp - Issue 452293004: Fix crash when node is moved in a selection

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderObject.cpp

Issue 452293004: Fix crash when node is moved in a selection (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Forgot to upload the test Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/rendering/RenderObject.cpp

diff --git a/Source/core/rendering/RenderObject.cpp b/Source/core/rendering/RenderObject.cpp

index 10e45c19c4e889a386a45498d3f680bf88eb2222..e42400623e2ace8deb448d041c2057235f63b47a 100644

--- a/Source/core/rendering/RenderObject.cpp

+++ b/Source/core/rendering/RenderObject.cpp

@@ -3359,7 +3359,7 @@ bool RenderObject::canUpdateSelectionOnRootLineBoxes()

return false;

RenderBlock* containingBlock = this->containingBlock();

- return containingBlock ? !containingBlock->needsLayout() : true;

+ return containingBlock ? !containingBlock->needsLayout() : false;

}

// We only create "generated" child renderers like one for first-letter if: