Issue 452273003: Fix crash in nvpr text after abandoning context

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 452273003: Fix crash in nvpr text after abandoning context (Closed)

Created:
6 years, 4 months ago by Chris Dalton

Modified:
6 years, 4 months ago

Reviewers:
Kimmo Kinnunen, bsalomon

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

More Reviews

Description

Fix crash in nvpr text after abandoning context Don't implement GlyphPathRange::onAbandon/onRelease. Its path range is also a GrGpuResource, registered with the gpu, and will automatically handle abandoning and releasing the actual GL objects. Don't delete the path range early, it is assumed to be a valid pointer throughout the entire lifetime of GlyphPathRange. BUG=skia: Committed: https://skia.googlesource.com/skia/+/3f860991ade1128e770c1268372f755a397e2942

Patch Set 1 #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -12 lines)			Patch
	M	src/gpu/GrStencilAndCoverTextContext.cpp	View		1 chunk	+0 lines, -12 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/cdalton@nvidia.com/452273003/1

6 years, 4 months ago (2014-08-11 19:36:57 UTC) #4

commit-bot: I haz the power

6 years, 4 months ago (2014-08-11 19:43:33 UTC) #5

Message was sent while issue was closed.

Change committed as 3f860991ade1128e770c1268372f755a397e2942

Expand Messages | Collapse Messages