Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issue 452263002: Clean up out/<target> directory in the end if extract_build. (Closed)

Created:
6 years, 4 months ago by zty
Modified:
6 years, 4 months ago
Reviewers:
navabi1, navabi, luqui
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Clean up out/<target> directory in the end if extract_build. Many slaves are shared between rel/dbg builders with the same build directory names. This makes sure we are testing what we intend to test. BUG=401781 R=navabi@chromium.org, luqui@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289042

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -8 lines) Patch
M build/android/buildbot/bb_device_steps.py View 2 chunks +5 lines, -0 lines 0 comments Download
M build/android/buildbot/bb_run_bot.py View 5 chunks +11 lines, -8 lines 0 comments Download

Messages

Total messages: 16 (0 generated)
zty
ptal
6 years, 4 months ago (2014-08-08 22:10:22 UTC) #1
luqui
lgtm
6 years, 4 months ago (2014-08-11 19:22:18 UTC) #2
zty
The CQ bit was checked by zty@chromium.org
6 years, 4 months ago (2014-08-11 19:39:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zty@chromium.org/452263002/1
6 years, 4 months ago (2014-08-11 19:41:45 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-11 19:41:47 UTC) #5
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 4 months ago (2014-08-11 19:41:48 UTC) #6
navabi
rs lgtm
6 years, 4 months ago (2014-08-11 21:37:53 UTC) #7
zty
The CQ bit was checked by zty@chromium.org
6 years, 4 months ago (2014-08-11 21:38:14 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zty@chromium.org/452263002/1
6 years, 4 months ago (2014-08-11 21:40:42 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-11 22:32:26 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-11 22:38:26 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/3465)
6 years, 4 months ago (2014-08-11 22:38:30 UTC) #12
navabi1
lgtm
6 years, 4 months ago (2014-08-12 01:09:34 UTC) #13
zty
The CQ bit was checked by zty@chromium.org
6 years, 4 months ago (2014-08-12 18:48:25 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zty@chromium.org/452263002/1
6 years, 4 months ago (2014-08-12 18:51:19 UTC) #15
commit-bot: I haz the power
6 years, 4 months ago (2014-08-12 19:05:31 UTC) #16
Message was sent while issue was closed.
Change committed as 289042

Powered by Google App Engine
This is Rietveld 408576698