Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Unified Diff: chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_api.cc

Issue 452243003: Add and update some Easy Unlock strings (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/app/generated_resources.grd ('K') | « chrome/app/generated_resources.grd ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_api.cc
diff --git a/chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_api.cc b/chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_api.cc
index 3680dc2202cbd0424d0cdb656edc62b55cb19974..6f03c2a29ebd2e4af1018d5e4fd031d1a620f5d6 100644
--- a/chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_api.cc
+++ b/chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_api.cc
@@ -63,6 +63,11 @@ bool EasyUnlockPrivateGetStringsFunction::RunSync() {
const base::string16 device_type = base::ASCIIToUTF16("Chromeschnozzle");
#endif // defined(OS_CHROMEOS)
+ // Common strings.
+ strings->SetString(
+ "learnMoreLink",
Ilya Sherman 2014/08/12 23:11:28 nit: Probably append "Title" to the name, both for
tbarzic 2014/08/13 00:44:17 Done.
+ l10n_util::GetStringUTF16(IDS_EASY_UNLOCK_LEARN_MORE_LINK));
+
// Setup notification strings.
strings->SetString(
"setupNotificationTitle",
@@ -86,6 +91,17 @@ bool EasyUnlockPrivateGetStringsFunction::RunSync() {
l10n_util::GetStringFUTF16(IDS_EASY_UNLOCK_SUCCESS_NOTIFICATION_MESSAGE,
device_type));
+ // Chromebook added to Easy Unlock notification strings.
+ strings->SetString(
+ "chromebookAddedNotificationTitle",
+ l10n_util::GetStringUTF16(
+ IDS_EASY_UNLOCK_CHROMEBOOK_ADDED_NOTIFICATION_TITLE));
+ strings->SetString(
+ "chromebookAddedNotificationMessage",
+ l10n_util::GetStringFUTF16(
+ IDS_EASY_UNLOCK_CHROMEBOOK_ADDED_NOTIFICATION_MESSAGE,
+ device_type));
+
// Setup dialog strings.
// Step 1: Intro.
strings->SetString(
@@ -109,6 +125,10 @@ bool EasyUnlockPrivateGetStringsFunction::RunSync() {
l10n_util::GetStringUTF16(
IDS_EASY_UNLOCK_SETUP_INTRO_FINDING_PHONE_BUTTON_LABEL));
strings->SetString(
+ "setupIntroRetryButtonLabel",
Ilya Sherman 2014/08/12 23:11:28 nit: It's nice to have the JS name match the .grd
tbarzic 2014/08/13 00:44:17 Done.
+ l10n_util::GetStringUTF16(
+ IDS_EASY_UNLOCK_SETUP_INTRO_RETRY_FIND_PHONE_BUTTON_LABEL));
+ strings->SetString(
"setupIntroHowIsThisSecureLinkText",
l10n_util::GetStringUTF16(
IDS_EASY_UNLOCK_SETUP_INTRO_HOW_IS_THIS_SECURE_LINK_TEXT));
@@ -125,6 +145,10 @@ bool EasyUnlockPrivateGetStringsFunction::RunSync() {
"setupFoundPhoneUseThisPhoneButtonLabel",
l10n_util::GetStringUTF16(
IDS_EASY_UNLOCK_SETUP_FOUND_PHONE_USE_THIS_PHONE_BUTTON_LABEL));
+ strings->SetString(
+ "setupFoundPhoneRestartButtonLabel",
+ l10n_util::GetStringUTF16(
+ IDS_EASY_UNLOCK_SETUP_PAIRING_PHONE_FAILED_BUTTON_LABEL));
Ilya Sherman 2014/08/12 23:11:28 Ditto.
tbarzic 2014/08/13 00:44:17 Done.
// Step 3: Setup completed successfully.
strings->SetString(
"setupCompleteHeaderTitle",
@@ -161,6 +185,15 @@ bool EasyUnlockPrivateGetStringsFunction::RunSync() {
IDS_EASY_UNLOCK_SETUP_ERROR_BLUETOOTH_CONNECTION_FAILED,
device_type));
strings->SetString(
+ "setupErrorConnectionToPhoneTimeout",
+ l10n_util::GetStringFUTF16(
+ IDS_EASY_UNLOCK_SETUP_ERROR_CONNECT_TO_PHONE_TIMEOUT,
+ device_type));
+ strings->SetString(
+ "setupErrorSyncPhoneState",
+ l10n_util::GetStringUTF16(
+ IDS_EASY_UNLOCK_SETUP_ERROR_SYNC_PHONE_STATE_FAILED));
+ strings->SetString(
"setupErrorConnectingToPhone",
l10n_util::GetStringFUTF16(
IDS_EASY_UNLOCK_SETUP_ERROR_CONNECTING_TO_PHONE, device_type));
« chrome/app/generated_resources.grd ('K') | « chrome/app/generated_resources.grd ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698