Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
452243003:
Add and update some Easy Unlock strings (Closed)
|
Created:
6 years, 4 months ago by tbarzic Modified:
6 years, 4 months ago CC:
chromium-reviews Base URL:
svn://svn.chromium.org/chrome/trunk/src Project:
chromium Visibility:
Public. |
DescriptionAdd and update some Easy Unlock strings
Updated strings for setup error messages
Added few new error strings
Added strings for "Adding Nth Chromebook" notification
Added strings for the screenlock
Added strings for setup dialog button label in error state.
BUG=393792, 397366, 397532, 402106, 402269, 402584, 401787
TEST=NONE
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289259
Patch Set 1 #Patch Set 2 : . #Patch Set 3 : . #Patch Set 4 : . #Patch Set 5 : . #Patch Set 6 : . #
Total comments: 32
Patch Set 7 : . #
Total comments: 1
Patch Set 8 : . #Patch Set 9 : . #
Total comments: 8
Patch Set 10 : . #Patch Set 11 : rebased #
Messages
Total messages: 22 (0 generated)
LGTM
https://codereview.chromium.org/452243003/diff/90001/chrome/app/generated_res... File chrome/app/generated_resources.grd (right): https://codereview.chromium.org/452243003/diff/90001/chrome/app/generated_res... chrome/app/generated_resources.grd:14418: + <message name="IDS_EASY_UNLOCK_CHROMEBOOK_ADDED_NOTIFICATION_TITLE" desc="Title for notification shown when the Chromebook is added to Easy Unlock."> nit: Perhaps "when an additional Chromebook is added"? (Ditto below.) https://codereview.chromium.org/452243003/diff/90001/chrome/app/generated_res... chrome/app/generated_resources.grd:14494: + Service is currently unavailable. Please try again later. Hmm, should this be "The service" rather than "Service"? Perhaps even "Sorry, the service"? https://codereview.chromium.org/452243003/diff/90001/chrome/app/generated_res... chrome/app/generated_resources.grd:14499: + <!-- Easy Unlock strings shown on the screenlock --> nit: "screenlock" -> "lock screen" https://codereview.chromium.org/452243003/diff/90001/chrome/app/generated_res... chrome/app/generated_resources.grd:14500: + <message name="IDS_EASY_UNLOCK_SCREENLOCK_TOOLTIP_NO_BLUETOOTH" desc="Tooltip for an icon on a user's screen lock pod shown by Easy Unlock when the Bluetooth is not turned on."> nit: I assume that this is when Bluetooth is not turned on on the Chromebook, rather than some other device. Please clarify that in the description. https://codereview.chromium.org/452243003/diff/90001/chrome/app/generated_res... chrome/app/generated_resources.grd:14501: + Turn on Bluetooth. This feels really brusque, especially given that I can't take this action from the lock screen. Do we want a more polite string, like "Easy unlock requires Bluetooth to be enabled." or "Please enable Bluetooth to easily unlock your [Chromebook]"? https://codereview.chromium.org/452243003/diff/90001/chrome/app/generated_res... chrome/app/generated_resources.grd:14503: + <message name="IDS_EASY_UNLOCK_SCREENLOCK_TOOLTIP_NO_PHONE" desc="Tooltip for an icon on a user's screen lock pod shown by Easy Unlock when a phone eligible to unlock the Chromebook cannot be found."> nit: "screen lock" -> "lock screen" (applies throughout) https://codereview.chromium.org/452243003/diff/90001/chrome/app/generated_res... chrome/app/generated_resources.grd:14504: + Can't find your Android phone. Make sure it's nearby and Bluetooth is turned on. We're inconsistent about using "Android phone" vs. just "phone". Should we try to make that consistent? https://codereview.chromium.org/452243003/diff/90001/chrome/app/generated_res... chrome/app/generated_resources.grd:14504: + Can't find your Android phone. Make sure it's nearby and Bluetooth is turned on. nit: Perhaps "Bluetooth is turned on" -> "has Bluetooth turned on" or "has Bluetooth enabled"? https://codereview.chromium.org/452243003/diff/90001/chrome/app/generated_res... chrome/app/generated_resources.grd:14507: + Unable to unlock. Enter your password. This is pretty vague. Can we give the user some hint at what action they can take to address the issue? https://codereview.chromium.org/452243003/diff/90001/chrome/app/generated_res... chrome/app/generated_resources.grd:14509: + <message name="IDS_EASY_UNLOCK_SCREENLOCK_TOOLTIP_PHONE_NOT_NEARBY" desc="Tooltip for an icon on a user's screen lock pod shown by Easy Unlock when a phone eligible to unlock the Chromebook is detected, but it's not in the Chromebook's proximity."> It's not clear to me how this is different from IDS_EASY_UNLOCK_SCREENLOCK_TOOLTIP_NO_PHONE. https://codereview.chromium.org/452243003/diff/90001/chrome/app/generated_res... chrome/app/generated_resources.grd:14525: + Click to enter nit: "Click" seems like a somewhat strange choice of verb, as I can also tap on the screen or press space on my keyboard. https://codereview.chromium.org/452243003/diff/90001/chrome/browser/extension... File chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_api.cc (right): https://codereview.chromium.org/452243003/diff/90001/chrome/browser/extension... chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_api.cc:68: "learnMoreLink", nit: Probably append "Title" to the name, both for the JS name and the .grd string name. https://codereview.chromium.org/452243003/diff/90001/chrome/browser/extension... chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_api.cc:128: "setupIntroRetryButtonLabel", nit: It's nice to have the JS name match the .grd name. I'm fine with either name, but let's be consistent :) https://codereview.chromium.org/452243003/diff/90001/chrome/browser/extension... chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_api.cc:151: IDS_EASY_UNLOCK_SETUP_PAIRING_PHONE_FAILED_BUTTON_LABEL)); Ditto.
https://codereview.chromium.org/452243003/diff/90001/chrome/app/generated_res... File chrome/app/generated_resources.grd (right): https://codereview.chromium.org/452243003/diff/90001/chrome/app/generated_res... chrome/app/generated_resources.grd:14494: + Service is currently unavailable. Please try again later. On 2014/08/12 23:11:27, Ilya Sherman wrote: > Hmm, should this be "The service" rather than "Service"? Perhaps even "Sorry, > the service"? I like it. Good idea. Let's go with: "Sorry, the service is currently unavailable. Please try again later." https://codereview.chromium.org/452243003/diff/90001/chrome/app/generated_res... chrome/app/generated_resources.grd:14501: + Turn on Bluetooth. On 2014/08/12 23:11:27, Ilya Sherman wrote: > This feels really brusque, especially given that I can't take this action from > the lock screen. Do we want a more polite string, like "Easy unlock requires > Bluetooth to be enabled." or "Please enable Bluetooth to easily unlock your > [Chromebook]"? Similar, but slightly different suggestion: "Please turn on Bluetooth to easily unlock your [Chromebook|Chromebox]." https://codereview.chromium.org/452243003/diff/90001/chrome/app/generated_res... chrome/app/generated_resources.grd:14504: + Can't find your Android phone. Make sure it's nearby and Bluetooth is turned on. On 2014/08/12 23:11:27, Ilya Sherman wrote: > We're inconsistent about using "Android phone" vs. just "phone". Should we try > to make that consistent? We've gone back and forth on this. Let's make it "Android phone" everywhere for now. @Toni, is that OK? Sorry for the hassle. https://codereview.chromium.org/452243003/diff/90001/chrome/app/generated_res... chrome/app/generated_resources.grd:14507: + Unable to unlock. Enter your password. On 2014/08/12 23:11:28, Ilya Sherman wrote: > This is pretty vague. Can we give the user some hint at what action they can > take to address the issue? I think the issue is that the user can't really do anything at this time. @Toni - Can you think of anything that the user could do? https://codereview.chromium.org/452243003/diff/90001/chrome/app/generated_res... chrome/app/generated_resources.grd:14525: + Click to enter On 2014/08/12 23:11:27, Ilya Sherman wrote: > nit: "Click" seems like a somewhat strange choice of verb, as I can also tap on > the screen or press space on my keyboard. Yeah, we went back and forth on this one also. :) Can you think of a better alternative?
https://codereview.chromium.org/452243003/diff/90001/chrome/app/generated_res... File chrome/app/generated_resources.grd (right): https://codereview.chromium.org/452243003/diff/90001/chrome/app/generated_res... chrome/app/generated_resources.grd:14525: + Click to enter On 2014/08/12 23:39:03, joshwoodward1 wrote: > On 2014/08/12 23:11:27, Ilya Sherman wrote: > > nit: "Click" seems like a somewhat strange choice of verb, as I can also tap > on > > the screen or press space on my keyboard. > > Yeah, we went back and forth on this one also. :) Can you think of a better > alternative? Hmm, fair point. I guess "Press" is slightly more general, but is also feels a little more awkward, so I'm not sure what a better alternative would be.
On 2014/08/13 00:19:11, Ilya Sherman wrote: > https://codereview.chromium.org/452243003/diff/90001/chrome/app/generated_res... > File chrome/app/generated_resources.grd (right): > > https://codereview.chromium.org/452243003/diff/90001/chrome/app/generated_res... > chrome/app/generated_resources.grd:14525: + Click to enter > On 2014/08/12 23:39:03, joshwoodward1 wrote: > > On 2014/08/12 23:11:27, Ilya Sherman wrote: > > > nit: "Click" seems like a somewhat strange choice of verb, as I can also tap > > on > > > the screen or press space on my keyboard. > > > > Yeah, we went back and forth on this one also. :) Can you think of a better > > alternative? > > Hmm, fair point. I guess "Press" is slightly more general, but is also feels a > little more awkward, so I'm not sure what a better alternative would be. I'm fine if we stay with "Click" then and see what user feedback looks like?
On 2014/08/13 00:23:41, joshwoodward1 wrote: > On 2014/08/13 00:19:11, Ilya Sherman wrote: > > > https://codereview.chromium.org/452243003/diff/90001/chrome/app/generated_res... > > File chrome/app/generated_resources.grd (right): > > > > > https://codereview.chromium.org/452243003/diff/90001/chrome/app/generated_res... > > chrome/app/generated_resources.grd:14525: + Click to enter > > On 2014/08/12 23:39:03, joshwoodward1 wrote: > > > On 2014/08/12 23:11:27, Ilya Sherman wrote: > > > > nit: "Click" seems like a somewhat strange choice of verb, as I can also > tap > > > on > > > > the screen or press space on my keyboard. > > > > > > Yeah, we went back and forth on this one also. :) Can you think of a better > > > alternative? > > > > Hmm, fair point. I guess "Press" is slightly more general, but is also feels > a > > little more awkward, so I'm not sure what a better alternative would be. > > I'm fine if we stay with "Click" then and see what user feedback looks like? SG.
https://codereview.chromium.org/452243003/diff/90001/chrome/app/generated_res... File chrome/app/generated_resources.grd (right): https://codereview.chromium.org/452243003/diff/90001/chrome/app/generated_res... chrome/app/generated_resources.grd:14418: + <message name="IDS_EASY_UNLOCK_CHROMEBOOK_ADDED_NOTIFICATION_TITLE" desc="Title for notification shown when the Chromebook is added to Easy Unlock."> On 2014/08/12 23:11:27, Ilya Sherman wrote: > nit: Perhaps "when an additional Chromebook is added"? (Ditto below.) that would imply that the notification is shown when another Chromebook is added, rather than this one. I tried to reformulate it.. https://codereview.chromium.org/452243003/diff/90001/chrome/app/generated_res... chrome/app/generated_resources.grd:14494: + Service is currently unavailable. Please try again later. On 2014/08/12 23:39:03, joshwoodward1 wrote: > On 2014/08/12 23:11:27, Ilya Sherman wrote: > > Hmm, should this be "The service" rather than "Service"? Perhaps even "Sorry, > > the service"? > > I like it. Good idea. Let's go with: "Sorry, the service is currently > unavailable. Please try again later." Done. https://codereview.chromium.org/452243003/diff/90001/chrome/app/generated_res... chrome/app/generated_resources.grd:14499: + <!-- Easy Unlock strings shown on the screenlock --> On 2014/08/12 23:11:27, Ilya Sherman wrote: > nit: "screenlock" -> "lock screen" Done. https://codereview.chromium.org/452243003/diff/90001/chrome/app/generated_res... chrome/app/generated_resources.grd:14500: + <message name="IDS_EASY_UNLOCK_SCREENLOCK_TOOLTIP_NO_BLUETOOTH" desc="Tooltip for an icon on a user's screen lock pod shown by Easy Unlock when the Bluetooth is not turned on."> On 2014/08/12 23:11:27, Ilya Sherman wrote: > nit: I assume that this is when Bluetooth is not turned on on the Chromebook, > rather than some other device. Please clarify that in the description. Done. https://codereview.chromium.org/452243003/diff/90001/chrome/app/generated_res... chrome/app/generated_resources.grd:14501: + Turn on Bluetooth. On 2014/08/12 23:39:03, joshwoodward1 wrote: > On 2014/08/12 23:11:27, Ilya Sherman wrote: > > This feels really brusque, especially given that I can't take this action from > > the lock screen. Do we want a more polite string, like "Easy unlock requires > > Bluetooth to be enabled." or "Please enable Bluetooth to easily unlock your > > [Chromebook]"? > > Similar, but slightly different suggestion: "Please turn on Bluetooth to easily > unlock your [Chromebook|Chromebox]." Done. https://codereview.chromium.org/452243003/diff/90001/chrome/app/generated_res... chrome/app/generated_resources.grd:14503: + <message name="IDS_EASY_UNLOCK_SCREENLOCK_TOOLTIP_NO_PHONE" desc="Tooltip for an icon on a user's screen lock pod shown by Easy Unlock when a phone eligible to unlock the Chromebook cannot be found."> On 2014/08/12 23:11:27, Ilya Sherman wrote: > nit: "screen lock" -> "lock screen" (applies throughout) Done. https://codereview.chromium.org/452243003/diff/90001/chrome/app/generated_res... chrome/app/generated_resources.grd:14504: + Can't find your Android phone. Make sure it's nearby and Bluetooth is turned on. On 2014/08/12 23:39:02, joshwoodward1 wrote: > On 2014/08/12 23:11:27, Ilya Sherman wrote: > > We're inconsistent about using "Android phone" vs. just "phone". Should we > try > > to make that consistent? > > We've gone back and forth on this. Let's make it "Android phone" everywhere for > now. @Toni, is that OK? Sorry for the hassle. Done. https://codereview.chromium.org/452243003/diff/90001/chrome/app/generated_res... chrome/app/generated_resources.grd:14507: + Unable to unlock. Enter your password. On 2014/08/12 23:39:03, joshwoodward1 wrote: > On 2014/08/12 23:11:28, Ilya Sherman wrote: > > This is pretty vague. Can we give the user some hint at what action they can > > take to address the issue? > > I think the issue is that the user can't really do anything at this time. @Toni > - Can you think of anything that the user could do? Not sure that there's a lot to do here. Adding Tim in case he has any ideas. https://codereview.chromium.org/452243003/diff/90001/chrome/app/generated_res... chrome/app/generated_resources.grd:14509: + <message name="IDS_EASY_UNLOCK_SCREENLOCK_TOOLTIP_PHONE_NOT_NEARBY" desc="Tooltip for an icon on a user's screen lock pod shown by Easy Unlock when a phone eligible to unlock the Chromebook is detected, but it's not in the Chromebook's proximity."> On 2014/08/12 23:11:27, Ilya Sherman wrote: > It's not clear to me how this is different from > IDS_EASY_UNLOCK_SCREENLOCK_TOOLTIP_NO_PHONE. I think this is for proximity check (we are able to connect to the phone, but we detect that it's too far away) +tengs to confirm To be honest I'm not completely sure if we really need this one for M38. https://codereview.chromium.org/452243003/diff/90001/chrome/browser/extension... File chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_api.cc (right): https://codereview.chromium.org/452243003/diff/90001/chrome/browser/extension... chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_api.cc:68: "learnMoreLink", On 2014/08/12 23:11:28, Ilya Sherman wrote: > nit: Probably append "Title" to the name, both for the JS name and the .grd > string name. Done. https://codereview.chromium.org/452243003/diff/90001/chrome/browser/extension... chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_api.cc:128: "setupIntroRetryButtonLabel", On 2014/08/12 23:11:28, Ilya Sherman wrote: > nit: It's nice to have the JS name match the .grd name. I'm fine with either > name, but let's be consistent :) Done. https://codereview.chromium.org/452243003/diff/90001/chrome/browser/extension... chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_api.cc:151: IDS_EASY_UNLOCK_SETUP_PAIRING_PHONE_FAILED_BUTTON_LABEL)); On 2014/08/12 23:11:28, Ilya Sherman wrote: > Ditto. Done.
LGTM, thanks :) https://codereview.chromium.org/452243003/diff/110001/chrome/app/generated_re... File chrome/app/generated_resources.grd (right): https://codereview.chromium.org/452243003/diff/110001/chrome/app/generated_re... chrome/app/generated_resources.grd:14422: + You can start using your phone to unlock this <ph name="DEVICE_TYPE">$1<ex>Chromebook</ex></ph>, too - no additional setup necessary. nit: "phone" -> "Android phone", per Josh's comment -- unless I misunderstood. Please double-check all the other strings as well.
I added 'Android' in front of 'phone' everywhere except for 'Find your phone'/'Use this phone' buttons in setup dialog. Josh, do you want me to change these too? Also, can you make another scan to see if everything's OK.
A few nits. Otherwise, LGTM and I agree about not saying "Android" in the case that you mentioned. Thanks! https://codereview.chromium.org/452243003/diff/150001/chrome/app/generated_re... File chrome/app/generated_resources.grd (right): https://codereview.chromium.org/452243003/diff/150001/chrome/app/generated_re... chrome/app/generated_resources.grd:14430: + Instantly unlock your <ph name="DEVICE_TYPE">$1<ex>Chromebook</ex></ph> when your Android phone is unlocked and with you—no password needed. Is there a space between "you" and "no". I think it should, "you - no password needed." https://codereview.chromium.org/452243003/diff/150001/chrome/app/generated_re... chrome/app/generated_resources.grd:14466: + If you have other Chrome devices, they'll be synced automatically so your Android phone can unlock them too. Minor nit: please put a comma before "too" at the end of the sentence. https://codereview.chromium.org/452243003/diff/150001/chrome/app/generated_re... chrome/app/generated_resources.grd:14479: + Can't find your Android phone. Make sure your <ph name="DEVICE_TYPE">$1<ex>Chromebook</ex></ph> has Bluetooth enabled. Minor nit: OLD: "Bluetooth enabled." NEW: "Bluetooth turned on." https://codereview.chromium.org/452243003/diff/150001/chrome/app/generated_re... chrome/app/generated_resources.grd:14504: + Can't find your Android phone. Make sure it's nearby and Bluetooth is turned on. OLD: Make sure it's nearby and Bluetooth is turned on. NEW: Make sure it's with you and Bluetooth is turned on.
https://codereview.chromium.org/452243003/diff/150001/chrome/app/generated_re... File chrome/app/generated_resources.grd (right): https://codereview.chromium.org/452243003/diff/150001/chrome/app/generated_re... chrome/app/generated_resources.grd:14430: + Instantly unlock your <ph name="DEVICE_TYPE">$1<ex>Chromebook</ex></ph> when your Android phone is unlocked and with you—no password needed. On 2014/08/13 01:54:54, joshwoodward1 wrote: > Is there a space between "you" and "no". I think it should, "you - no password > needed." Done. https://codereview.chromium.org/452243003/diff/150001/chrome/app/generated_re... chrome/app/generated_resources.grd:14466: + If you have other Chrome devices, they'll be synced automatically so your Android phone can unlock them too. On 2014/08/13 01:54:54, joshwoodward1 wrote: > Minor nit: please put a comma before "too" at the end of the sentence. Done. https://codereview.chromium.org/452243003/diff/150001/chrome/app/generated_re... chrome/app/generated_resources.grd:14479: + Can't find your Android phone. Make sure your <ph name="DEVICE_TYPE">$1<ex>Chromebook</ex></ph> has Bluetooth enabled. On 2014/08/13 01:54:54, joshwoodward1 wrote: > Minor nit: OLD: "Bluetooth enabled." NEW: "Bluetooth turned on." Done. https://codereview.chromium.org/452243003/diff/150001/chrome/app/generated_re... chrome/app/generated_resources.grd:14504: + Can't find your Android phone. Make sure it's nearby and Bluetooth is turned on. On 2014/08/13 01:54:54, joshwoodward1 wrote: > OLD: Make sure it's nearby and Bluetooth is turned on. > NEW: Make sure it's with you and Bluetooth is turned on. Done.
Boom. Ship it!
The CQ bit was checked by tbarzic@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tbarzic@chromium.org/452243003/170001
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...) mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/40923) win_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/46148) android_aosp on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/bu...) android_chromium_gn_compile_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...) android_clang_dbg on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...) android_dbg on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg/bui...) chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...) linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_gn_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_rel_swarming on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) ios_dbg_simulator on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...) ios_rel_device on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device/bu...) ios_rel_device_ninja on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...) mac_chromium_compile_dbg on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...) mac_chromium_rel_swarming on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...) win8_chromium_rel on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel...) win_chromium_compile_dbg on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...) win_chromium_rel_swarming on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...) win_chromium_x64_rel on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/40926) ios_dbg_simulator on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...) ios_rel_device on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device/bu...) ios_rel_device_ninja on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...) mac_chromium_compile_dbg on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...) mac_chromium_rel_swarming on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by tbarzic@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tbarzic@chromium.org/452243003/190001
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_aosp on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/bu...)
Message was sent while issue was closed.
Change committed as 289259 |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
