Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(574)

Unified Diff: net/http/transport_security_state.cc

Issue 452183002: Perform dynamic pin checks even when the build is not timely. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix comments from rsleevi Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/http/transport_security_state.cc
diff --git a/net/http/transport_security_state.cc b/net/http/transport_security_state.cc
index 508784ea399c53817f1d7f43fb1e2b700c9696e0..d452651f28fe31477e7583a7f02bc30765b06a9c 100644
--- a/net/http/transport_security_state.cc
+++ b/net/http/transport_security_state.cc
@@ -133,14 +133,8 @@ bool TransportSecurityState::CheckPublicKeyPins(
//
// * the server's certificate chain chains up to a known root (i.e. not a
// user-installed trust anchor); and
- // * the build is recent (very old builds should fail open so that users
- // have some chance to recover).
// * the server actually has public key pins.
- //
- // TODO(rsleevi): http://crbug.com/391032 - Only disable static HPKP if the
- // build is not timely.
- if (!is_issued_by_known_root || !IsBuildTimely() ||
- !HasPublicKeyPins(host, sni_available)) {
+ if (!is_issued_by_known_root || !HasPublicKeyPins(host, sni_available)) {
return true;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698