Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 452133002: Revert 288319 "Adding the VerifyModule function (and helpers) to..." (Closed)

Created:
6 years, 4 months ago by tommi (sloooow) - chröme
Modified:
6 years, 4 months ago
Reviewers:
krstnmnlsn
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 288319 "Adding the VerifyModule function (and helpers) to..." The tests were crashing on the windows bots (e.g. http://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%283%29/builds/29877/steps/unit_tests/logs/VerifyModuleModified): SafeBrowsingModuleVerifierWinTest.VerifyModuleModified (run #1): [ RUN ] SafeBrowsingModuleVerifierWinTest.VerifyModuleModified c:\b\build\slave\win_builder\build\src\chrome\browser\safe_browsing\module_integrity_verifier_win_unittest.cc(43): error: Value of: mem_dll_handle_.is_valid() Actual: false Expected: true c:\b\build\slave\win_builder\build\src\chrome\browser\safe_browsing\module_integrity_verifier_win_unittest.cc(48): error: Expected: (static_cast\u003CHMODULE>(0)) != (*mem_handle), actual: NULL vs NULL Backtrace: RelaunchChromeBrowserWithNewCommandLineIfNeeded [0x0278AD98+6714120] (No symbol) [0x01761388] RelaunchChromeBrowserWithNewCommandLineIfNeeded [0x02493F49+3605689] RelaunchChromeBrowserWithNewCommandLineIfNeeded [0x024940CE+3606078] RelaunchChromeBrowserWithNewCommandLineIfNeeded [0x024946AE+3607582] RelaunchChromeBrowserWithNewCommandLineIfNeeded [0x024943E9+3606873] IsSandboxedProcess [0x0465F878+12316280] IsSandboxedProcess [0x0465F5AA+12315562] IsSandboxedProcess [0x04683A62+12464226] IsSandboxedProcess [0x045801B7+11401143] BaseThreadInitThunk [0x74C0338A+18] RtlInitializeExceptionChain [0x77299F72+99] RtlInitializeExceptionChain [0x77299F45+54] > Adding the VerifyModule function (and helpers) to safe browsing. > > This function allows us to compare a module in memory with > its original on disk, and identify any differences (after > accounting for relocations). The state of the module > (MODULE_UNKNOWN, MODULE_UNMODIFIED or MODULE_MODIFIED) is > returned along with a list of the possibly modified exported > functions of the module. > > > BUG=401854 > > Review URL: https://codereview.chromium.org/406043003 TBR=krstnmnlsn@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288348

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -35 lines) Patch
D trunk/src/chrome/browser/safe_browsing/verifier_test/verifier_test_dll.cc View 1 chunk +0 lines, -15 lines 0 comments Download
D trunk/src/chrome/browser/safe_browsing/verifier_test/verifier_test_dll.def View 1 chunk +0 lines, -8 lines 0 comments Download
D trunk/src/chrome/browser/safe_browsing/verifier_test/verifier_unittest.gyp View 1 chunk +0 lines, -12 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
tommi (sloooow) - chröme
6 years, 4 months ago (2014-08-08 14:03:26 UTC) #1
tommi (sloooow) - chröme
Committed patchset #1 manually as r288348.
6 years, 4 months ago (2014-08-08 14:03:58 UTC) #2
tommi (sloooow) - chröme
6 years, 4 months ago (2014-08-08 14:14:44 UTC) #3
Message was sent while issue was closed.
On 2014/08/08 14:03:58, tommi wrote:
> Committed patchset #1 manually as r288348.

ugh, this doesn't look good! fixing

Powered by Google App Engine
This is Rietveld 408576698