Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Unified Diff: tools/chrome_proxy/integration_tests/chrome_proxy_measurements.py

Issue 452123002: Rename ValidatePage/MeasurePage -> ValidateAndMeasurePage for all files outside tools/telemetry and… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/test/gpu/gpu_tests/webgl_conformance.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/chrome_proxy/integration_tests/chrome_proxy_measurements.py
diff --git a/tools/chrome_proxy/integration_tests/chrome_proxy_measurements.py b/tools/chrome_proxy/integration_tests/chrome_proxy_measurements.py
index 111070971b4c0227ff8d4abf0059e809cf658d6a..fd92a4dfabc213aef111c058c9593b719367b5db 100644
--- a/tools/chrome_proxy/integration_tests/chrome_proxy_measurements.py
+++ b/tools/chrome_proxy/integration_tests/chrome_proxy_measurements.py
@@ -21,7 +21,7 @@ class ChromeProxyLatency(page_test.PageTest):
def WillNavigateToPage(self, page, tab):
tab.ClearCache(force=True)
- def MeasurePage(self, page, tab, results):
+ def ValidateAndMeasurePage(self, page, tab, results):
# Wait for the load event.
tab.WaitForJavaScriptExpression('performance.timing.loadEventStart', 300)
loading.LoadingMetric().AddResults(tab, results)
@@ -37,7 +37,7 @@ class ChromeProxyDataSaving(page_test.PageTest):
tab.ClearCache(force=True)
self._metrics.Start(page, tab)
- def MeasurePage(self, page, tab, results):
+ def ValidateAndMeasurePage(self, page, tab, results):
# Wait for the load event.
tab.WaitForJavaScriptExpression('performance.timing.loadEventStart', 300)
self._metrics.Stop(page, tab)
@@ -64,7 +64,7 @@ class ChromeProxyValidation(page_test.PageTest):
assert self._metrics
self._metrics.Start(page, tab)
- def MeasurePage(self, page, tab, results):
+ def ValidateAndMeasurePage(self, page, tab, results):
self._page = page
# Wait for the load event.
tab.WaitForJavaScriptExpression('performance.timing.loadEventStart', 300)
« no previous file with comments | « content/test/gpu/gpu_tests/webgl_conformance.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698