Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Side by Side Diff: content/test/gpu/gpu_tests/maps.py

Issue 452123002: Rename ValidatePage/MeasurePage -> ValidateAndMeasurePage for all files outside tools/telemetry and… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2013 The Chromium Authors. All rights reserved. 1 # Copyright 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 """Runs a Google Maps pixel test. 5 """Runs a Google Maps pixel test.
6 Performs several common navigation actions on the map (pan, zoom, rotate) then 6 Performs several common navigation actions on the map (pan, zoom, rotate) then
7 captures a screenshot and compares selected pixels against expected values""" 7 captures a screenshot and compares selected pixels against expected values"""
8 8
9 import json 9 import json
10 import optparse 10 import optparse
11 import os 11 import os
12 12
13 import cloud_storage_test_base 13 import cloud_storage_test_base
14 import maps_expectations 14 import maps_expectations
15 15
16 from telemetry import benchmark 16 from telemetry import benchmark
17 from telemetry.core import bitmap 17 from telemetry.core import bitmap
18 from telemetry.core import util 18 from telemetry.core import util
19 from telemetry.page import page 19 from telemetry.page import page
20 from telemetry.page import page_set 20 from telemetry.page import page_set
21 from telemetry.page import page_test 21 from telemetry.page import page_test
22 22
23 class _MapsValidator(cloud_storage_test_base.ValidatorBase): 23 class _MapsValidator(cloud_storage_test_base.ValidatorBase):
24 def CustomizeBrowserOptions(self, options): 24 def CustomizeBrowserOptions(self, options):
25 options.AppendExtraBrowserArgs('--enable-gpu-benchmarking') 25 options.AppendExtraBrowserArgs('--enable-gpu-benchmarking')
26 26
27 def ValidatePage(self, page, tab, results): 27 def ValidateAndMeasurePage(self, page, tab, results):
28 # TODO: This should not be necessary, but it's not clear if the test is 28 # TODO: This should not be necessary, but it's not clear if the test is
29 # failing on the bots in it's absence. Remove once we can verify that it's 29 # failing on the bots in it's absence. Remove once we can verify that it's
30 # safe to do so. 30 # safe to do so.
31 _MapsValidator.SpinWaitOnRAF(tab, 3) 31 _MapsValidator.SpinWaitOnRAF(tab, 3)
32 32
33 if not tab.screenshot_supported: 33 if not tab.screenshot_supported:
34 raise page_test.Failure('Browser does not support screenshot capture') 34 raise page_test.Failure('Browser does not support screenshot capture')
35 screenshot = tab.Screenshot(5) 35 screenshot = tab.Screenshot(5)
36 if not screenshot: 36 if not screenshot:
37 raise page_test.Failure('Could not capture screenshot') 37 raise page_test.Failure('Could not capture screenshot')
(...skipping 56 matching lines...) Expand 10 before | Expand all | Expand 10 after
94 return maps_expectations.MapsExpectations() 94 return maps_expectations.MapsExpectations()
95 95
96 def CreatePageSet(self, options): 96 def CreatePageSet(self, options):
97 page_set_path = os.path.join( 97 page_set_path = os.path.join(
98 util.GetChromiumSrcDir(), 'content', 'test', 'gpu', 'page_sets') 98 util.GetChromiumSrcDir(), 'content', 'test', 'gpu', 'page_sets')
99 ps = page_set.PageSet(archive_data_file='data/maps.json', 99 ps = page_set.PageSet(archive_data_file='data/maps.json',
100 make_javascript_deterministic=False, 100 make_javascript_deterministic=False,
101 file_path=page_set_path) 101 file_path=page_set_path)
102 ps.AddPage(MapsPage(ps, ps.base_dir)) 102 ps.AddPage(MapsPage(ps, ps.base_dir))
103 return ps 103 return ps
OLDNEW
« no previous file with comments | « content/test/gpu/gpu_tests/hardware_accelerated_feature.py ('k') | content/test/gpu/gpu_tests/memory.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698