Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(743)

Unified Diff: chrome/browser/ui/webui/options/browser_options_browsertest.js

Issue 452113002: Disable Uber navigation for Settings & Help overlays (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/options/browser_options_browsertest.js
diff --git a/chrome/browser/ui/webui/options/browser_options_browsertest.js b/chrome/browser/ui/webui/options/browser_options_browsertest.js
index bb6240da88e5cce99d0262da3ff4e3973ceeb8ce..c9055dd15c1193a316403a6cfbc517ba5fb76b06 100644
--- a/chrome/browser/ui/webui/options/browser_options_browsertest.js
+++ b/chrome/browser/ui/webui/options/browser_options_browsertest.js
@@ -26,8 +26,28 @@ GEN('#define MAYBE_testOpenBrowserOptions testOpenBrowserOptions');
GEN('#endif // defined(OS_MACOSX)');
TEST_F('BrowserOptionsWebUITest', 'MAYBE_testOpenBrowserOptions', function() {
assertEquals(this.browsePreload, document.location.href);
+ expectFalse($('navigation').classList.contains('background'));
});
+/**
+ * TestFixture for the uber page when the browser options page has an overlay.
+ * @extends {testing.Test}
+ * @constructor
+ */
+function BrowserOptionsOverlayWebUITest() {}
+
+BrowserOptionsOverlayWebUITest.prototype = {
+ __proto__: testing.Test.prototype,
+
+ /** @override */
+ browsePreload: 'chrome://chrome/settings/autofill',
+};
+
+TEST_F('BrowserOptionsOverlayWebUITest', 'testNavigationInBackground',
+ function() {
+ assertEquals(this.browsePreload, document.location.href);
+ expectTrue($('navigation').classList.contains('background'));
+});
/**
* @extends {testing.Test}
@@ -48,7 +68,6 @@ TEST_F('BrowserOptionsFrameWebUITest', 'testAdvancedSettingsHiddenByDefault',
expectTrue($('advanced-settings').hidden);
});
-
/**
* @extends {testing.Test}
* @constructor
« chrome/browser/resources/help/help.js ('K') | « chrome/browser/resources/options/options.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698