DevTools: Implement CSS/JS documentation context menu provider for CodeMirrorTextEditor

Patch creates an experimental item in context menu which will be used for documentation.

BUG=391593
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179930

[yurys, 2014-08-08 13:07:47]

https://codereview.chromium.org/452083002/diff/1/Source/devtools/front_end/co...
File Source/devtools/front_end/common/Settings.js (right):

https://codereview.chromium.org/452083002/diff/1/Source/devtools/front_end/co...
Source/devtools/front_end/common/Settings.js:297: this.documentation =
this._createExperiment("documentation", "Documentation for JS and CSS");
hidden=true?

https://codereview.chromium.org/452083002/diff/1/Source/devtools/front_end/do...
File Source/devtools/front_end/documentation/DocumentationView.js (right):

https://codereview.chromium.org/452083002/diff/1/Source/devtools/front_end/do...
Source/devtools/front_end/documentation/DocumentationView.js:26: var view =
WebInspector.DocumentationView._view;
Inline this.

https://codereview.chromium.org/452083002/diff/1/Source/devtools/front_end/ma...
File Source/devtools/front_end/main/Main.js (right):

https://codereview.chromium.org/452083002/diff/1/Source/devtools/front_end/ma...
Source/devtools/front_end/main/Main.js:192: if
(WebInspector.experimentsSettings.documentation.isEnabled())
You should also register documentation module by default in _createModuleManager
in Main.js

[apavlov, 2014-08-08 13:13:52]

https://codereview.chromium.org/452083002/diff/1/Source/devtools/front_end/do...
File Source/devtools/front_end/documentation/DocumentationView.js (right):

https://codereview.chromium.org/452083002/diff/1/Source/devtools/front_end/do...
Source/devtools/front_end/documentation/DocumentationView.js:57:
_appendTextEditorItems: function(contextMenu, target)
This can be inlined, too

[yurys, 2014-08-08 13:21:07]

https://codereview.chromium.org/452083002/diff/1/Source/devtools/front_end/ma...
File Source/devtools/front_end/main/Main.js (right):

https://codereview.chromium.org/452083002/diff/1/Source/devtools/front_end/ma...
Source/devtools/front_end/main/Main.js:192: if
(WebInspector.experimentsSettings.documentation.isEnabled())
On 2014/08/08 13:07:47, yurys wrote:
> You should also register documentation module by default in
_createModuleManager
> in Main.js

Never mind.

[apavlov, 2014-08-08 13:24:07]

Issue subjects should give a high-level description of what the patch does, not
what its author has done code-wise (since it does not give a clue to people not
closely familiar with your code.) E.g.: "DevTools: Implement code documentation
context menu provider for CodeMirrorTextEditor". Technical details can be
covered in the issue description, though.

[semeny, 2014-08-08 14:54:45]

https://codereview.chromium.org/452083002/diff/1/Source/devtools/front_end/co...
File Source/devtools/front_end/common/Settings.js (right):

https://codereview.chromium.org/452083002/diff/1/Source/devtools/front_end/co...
Source/devtools/front_end/common/Settings.js:297: this.documentation =
this._createExperiment("documentation", "Documentation for JS and CSS");
On 2014/08/08 13:07:47, yurys wrote:
> hidden=true?

Done.

https://codereview.chromium.org/452083002/diff/1/Source/devtools/front_end/do...
File Source/devtools/front_end/documentation/DocumentationView.js (right):

https://codereview.chromium.org/452083002/diff/1/Source/devtools/front_end/do...
Source/devtools/front_end/documentation/DocumentationView.js:57:
_appendTextEditorItems: function(contextMenu, target)
On 2014/08/08 13:13:52, apavlov wrote:
> This can be inlined, too

Done.

[yurys, 2014-08-11 08:21:27]

lgtm

[commit-bot: I haz the power, 2014-08-11 08:21:36]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/semeny@google.com/452083002/40001

[commit-bot: I haz the power, 2014-08-11 08:25:53]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_blink_compile_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/android_blink_compile_db...)
  android_blink_compile_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/android_blink_compile_re...)
  android_chromium_gn_compile_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/android_chromium_gn_comp...)
  blink_presubmit on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/1...)
  linux_blink_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/2...)
  linux_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/1...)
  linux_chromium_gn_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_chromium_gn_rel/bu...)
  mac_blink_compile_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/mac_blink_compile_dbg/bu...)
  mac_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/19233)
  win_blink_compile_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_compile_dbg/bu...)
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/21995)
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/39870)
  win_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/45115)

[semeny, 2014-08-11 08:27:06]

The CQ bit was unchecked by semeny@google.com

[semeny, 2014-08-11 08:32:06]

The CQ bit was checked by semeny@google.com

[commit-bot: I haz the power, 2014-08-11 08:32:47]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/semeny@google.com/452083002/60001

[semeny, 2014-08-11 08:36:58]

The CQ bit was unchecked by semeny@google.com

[lushnikov, 2014-08-11 09:31:56]

lgtm

[iliia, 2014-08-11 09:32:44]

The CQ bit was checked by iliia@google.com

[semeny, 2014-08-11 09:32:44]

The CQ bit was checked by semeny@google.com

[commit-bot: I haz the power, 2014-08-11 09:32:56]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/semeny@google.com/452083002/60001

[commit-bot: I haz the power, 2014-08-11 09:43:50]

Change committed as 179930