[SyncFS] Crash fix on chrome://syncfs-internals

[SyncFS] Crash fix on chrome://syncfs-internals

BUG=401906
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288351

[tzik, 2014-08-08 09:39:26]

PTL

[peria, 2014-08-08 09:45:05]

https://codereview.chromium.org/452063002/diff/1/chrome/browser/sync_file_sys...
File chrome/browser/sync_file_system/sync_file_system_service.cc (right):

https://codereview.chromium.org/452063002/diff/1/chrome/browser/sync_file_sys...
chrome/browser/sync_file_system/sync_file_system_service.cc:538: if (list)
Change for this part seems to do nothing, in actual.

https://codereview.chromium.org/452063002/diff/1/chrome/browser/sync_file_sys...
chrome/browser/sync_file_system/sync_file_system_service.cc:555:
v1list.reset(new base::ListValue);
= make_scoped_ptr(new base::ListValue);

to be same with #535?

https://codereview.chromium.org/452063002/diff/1/chrome/browser/sync_file_sys...
chrome/browser/sync_file_system/sync_file_system_service.cc:572: if
(!v2_remote_service_) {
I recommend to put 

if (!status_map)
  status_map = make_scoped_ptr(new ....);

between #571 and #572

[tzik, 2014-08-08 09:50:57]

https://codereview.chromium.org/452063002/diff/1/chrome/browser/sync_file_sys...
File chrome/browser/sync_file_system/sync_file_system_service.cc (right):

https://codereview.chromium.org/452063002/diff/1/chrome/browser/sync_file_sys...
chrome/browser/sync_file_system/sync_file_system_service.cc:538: if (list)
On 2014/08/08 09:45:04, peria wrote:
> Change for this part seems to do nothing, in actual.

Done.

https://codereview.chromium.org/452063002/diff/1/chrome/browser/sync_file_sys...
chrome/browser/sync_file_system/sync_file_system_service.cc:555:
v1list.reset(new base::ListValue);
On 2014/08/08 09:45:05, peria wrote:
> = make_scoped_ptr(new base::ListValue);
> 
> to be same with #535?

Done.

https://codereview.chromium.org/452063002/diff/1/chrome/browser/sync_file_sys...
chrome/browser/sync_file_system/sync_file_system_service.cc:572: if
(!v2_remote_service_) {
On 2014/08/08 09:45:04, peria wrote:
> I recommend to put 
> 
> if (!status_map)
>   status_map = make_scoped_ptr(new ....);
> 
> between #571 and #572

Done.

[peria, 2014-08-08 09:51:30]

lgtm

[tzik, 2014-08-08 09:51:35]

The CQ bit was checked by tzik@chromium.org

[commit-bot: I haz the power, 2014-08-08 09:54:21]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/tzik@chromium.org/452063002/20001

[commit-bot: I haz the power, 2014-08-08 14:10:20]

Change committed as 288351