chrome/browser/file_system/OWNERS - Issue 452043003: [ew] Add basic classes.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/file_system/OWNERS

Issue 452043003: [ew] Add basic classes. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Addressed comments. Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« chrome/browser/extensions/api/file_system/file_system_api.cc ('K') | « chrome/browser/extensions/api/file_system/file_system_api.cc ('k') | chrome/browser/file_system/entry_watcher_service.h » ('j') | chrome/browser/file_system/entry_watcher_service.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 benwells@chromium.org	1 benwells@chromium.org
	benwells 2014/08/13 05:50:47 Why are you creating a new chrome/browser/file_sys Why are you creating a new chrome/browser/file_system folder? mtomasz 2014/08/13 07:02:08 We used to put just api method implementations in Show quoted text On 2014/08/13 05:50:47, benwells wrote: > Why are you creating a new chrome/browser/file_system folder? We used to put just api method implementations in /c/b/extensions/api, while meat such as services in /c/b. See: /c/b/chromeos/extensions/file_manager vs. /c/b/chromeos/file_manager /c/b/chromeos/extensions/file_system_provider vs. /c/b/chromeos/file_system_provider However if you think that it should go to /c/b/extensions/api, then I'm fine too. On the other hand SavedFilesService is very deep in /apps. I'm not sure what's the best place for this service. WDYT? benwells 2014/08/14 05:16:32 I would start in c/b/extensionns/api. We put Saved Show quoted text On 2014/08/13 07:02:08, mtomasz wrote: > On 2014/08/13 05:50:47, benwells wrote: > > Why are you creating a new chrome/browser/file_system folder? > > We used to put just api method implementations in /c/b/extensions/api, while > meat such as services in /c/b. > > See: > /c/b/chromeos/extensions/file_manager vs. /c/b/chromeos/file_manager > /c/b/chromeos/extensions/file_system_provider vs. > /c/b/chromeos/file_system_provider > > However if you think that it should go to /c/b/extensions/api, then I'm fine > too. > On the other hand SavedFilesService is very deep in /apps. > > I'm not sure what's the best place for this service. WDYT? I would start in c/b/extensionns/api. We put SavedFilesService deep in apps as it is used by multiple APIs - the file system and also the runtime api, I think. If this isn't needed outside of the c/b/extensions/api/file_system i'd leave it there.
	2 mtomasz@chromium.org

2 sammc@chromium.org	3 sammc@chromium.org

OLD	NEW