chrome/browser/extensions/api/file_system/file_system_api.cc - Issue 452043003: [ew] Add basic classes.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/extensions/api/file_system/file_system_api.cc

Issue 452043003: [ew] Add basic classes. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Addressed comments. Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "chrome/browser/extensions/api/file_system/file_system_api.h"	5 #include "chrome/browser/extensions/api/file_system/file_system_api.h"

6	6

	7 #include <set>

	8 #include <string>
	benwells 2014/08/13 05:50:46 As <string> is in the .h now you shouldn't need it As <string> is in the .h now you shouldn't need it here. mtomasz 2014/08/13 07:02:08 Done. Show quoted text On 2014/08/13 05:50:46, benwells wrote: > As <string> is in the .h now you shouldn't need it here. Done. benwells 2014/08/13 23:57:02 Is there meant to be a new patch set? Show quoted text On 2014/08/13 07:02:08, mtomasz wrote: > On 2014/08/13 05:50:46, benwells wrote: > > As <string> is in the .h now you shouldn't need it here. > > Done. Is there meant to be a new patch set?
	9

7 #include "apps/app_window.h"	10 #include "apps/app_window.h"

8 #include "apps/app_window_registry.h"	11 #include "apps/app_window_registry.h"

9 #include "apps/saved_files_service.h"	12 #include "apps/saved_files_service.h"

10 #include "base/bind.h"	13 #include "base/bind.h"

11 #include "base/file_util.h"	14 #include "base/file_util.h"

12 #include "base/files/file_path.h"	15 #include "base/files/file_path.h"

13 #include "base/logging.h"	16 #include "base/logging.h"

14 #include "base/path_service.h"	17 #include "base/path_service.h"

15 #include "base/strings/string_util.h"	18 #include "base/strings/string_util.h"

16 #include "base/strings/stringprintf.h"	19 #include "base/strings/stringprintf.h"

(...skipping 925 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
942 return false;	945 return false;

943 }	946 }

944	947

945 bool FileSystemGetObservedEntriesFunction::RunSync() {	948 bool FileSystemGetObservedEntriesFunction::RunSync() {

946 NOTIMPLEMENTED();	949 NOTIMPLEMENTED();

947 error_ = kUnknownIdError;	950 error_ = kUnknownIdError;

948 return false;	951 return false;

949 }	952 }

950	953

951 } // namespace extensions	954 } // namespace extensions

OLD	NEW

« no previous file with comments | « chrome/browser/extensions/api/file_system/file_system_api.h ('k') | chrome/browser/file_system/OWNERS » ('j') | chrome/browser/file_system/OWNERS » ('J')