InjectedScriptManager::CallbackData should be disposed when an associated worker thread terminates

InjectedScriptManager::CallbackData should be disposed when an associated worker thread terminates

CallbackData created by InjectedScriptManager should be deleted when
an associated worker thread terminates. The most straightforward way
to do that is to make the InjectedScriptManager hold a list of
OwnPtr<CallbackData> that the InjectedScriptManager created.
Since the the InjectedScriptManager is destructed in ~WorkerScriptController(), it's guaranteed that all associated CallbackData is destructed
in
~WorkerScriptController() as well.

This change will fix a couple of inspector-protocol/debugger tests in oilpan builds.

BUG=398472
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179905

[haraken, 2014-08-08 10:20:32]

yurys@: PTAL

I noticed that all wrappers in DOMWrapperMap are already handled correctly when
a worker thread shuts down. So, what we need is just to add a special logic to
CallbackData so that it can be collected at worker's shutdown (we need a special
logic because CallbackData is not registered to DOMWrapperMap). The most
straightforward way to do that is just to make the InjectedScriptManager hold a
list of OwnPtr<CallbackData> that the InjectedScriptManager has created. Since a
WorkerScriptController holds an OwnPtr<InjectedScriptManager>, we can guarantee
that the InjectedScriptManager and its associated CallbackData is destructed
when the WorkerScriptController is destructed.

[yurys, 2014-08-08 12:23:22]

LGTM.

Would be nice to eventually make InjectedScriptHost use the same wrapper
creation logic as for other DOM bindings.

[yurys, 2014-08-08 12:24:34]

The CQ bit was checked by yurys@chromium.org

[commit-bot: I haz the power, 2014-08-08 12:25:10]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/haraken@chromium.org/452043002/1

[commit-bot: I haz the power, 2014-08-08 13:49:40]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_blink_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/2...)
  linux_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/1...)
  mac_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/19006)
  win_blink_compile_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_compile_dbg/bu...)
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/21745)
  linux_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu_trigger...)
  mac_gpu_retina_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu_retina_tr...)
  mac_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu_triggered...)
  win_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered...)

[commit-bot: I haz the power, 2014-08-08 14:06:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-08 14:06:52]

Try jobs failed on following builders:
  mac_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu_triggered...)

[haraken, 2014-08-11 02:09:06]

The CQ bit was checked by haraken@chromium.org

[commit-bot: I haz the power, 2014-08-11 02:09:40]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/haraken@chromium.org/452043002/20001

[commit-bot: I haz the power, 2014-08-11 03:08:49]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/21943)

[commit-bot: I haz the power, 2014-08-11 03:48:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-11 03:48:18]

Try jobs failed on following builders:
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/21948)

[haraken, 2014-08-11 03:48:31]

The CQ bit was checked by haraken@chromium.org

[commit-bot: I haz the power, 2014-08-11 03:48:42]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/haraken@chromium.org/452043002/20001

[commit-bot: I haz the power, 2014-08-11 04:18:26]

Change committed as 179905

[aandrey, 2014-08-11 07:36:17]

https://codereview.chromium.org/452043002/diff/20001/Source/bindings/core/v8/...
File Source/bindings/core/v8/custom/V8InjectedScriptManager.cpp (right):

https://codereview.chromium.org/452043002/diff/20001/Source/bindings/core/v8/...
Source/bindings/core/v8/custom/V8InjectedScriptManager.cpp:60: fprintf(stderr,
"b %p\n", callbackData);
this also got commited

[haraken, 2014-08-11 07:40:20]

https://codereview.chromium.org/452043002/diff/20001/Source/bindings/core/v8/...
File Source/bindings/core/v8/custom/V8InjectedScriptManager.cpp (right):

https://codereview.chromium.org/452043002/diff/20001/Source/bindings/core/v8/...
Source/bindings/core/v8/custom/V8InjectedScriptManager.cpp:60: fprintf(stderr,
"b %p\n", callbackData);
On 2014/08/11 07:36:17, aandrey wrote:
> this also got commited

oh, sorry. Let me fix it asap.

[haraken, 2014-08-11 07:40:28]

On 2014/08/11 07:40:20, haraken wrote:
>
https://codereview.chromium.org/452043002/diff/20001/Source/bindings/core/v8/...
> File Source/bindings/core/v8/custom/V8InjectedScriptManager.cpp (right):
> 
>
https://codereview.chromium.org/452043002/diff/20001/Source/bindings/core/v8/...
> Source/bindings/core/v8/custom/V8InjectedScriptManager.cpp:60: fprintf(stderr,
> "b %p\n", callbackData);
> On 2014/08/11 07:36:17, aandrey wrote:
> > this also got commited
> 
> oh, sorry. Let me fix it asap.

Fixed in r179913.