Issue 452017: Http cache: Add code to restart a network request when the...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 452017: Http cache: Add code to restart a network request when the... (Closed)

Created:
11 years ago by rvargas (doing something else)

Modified:
9 years, 6 months ago

Reviewers:
eroman

CC:
chromium-reviews_googlegroups.com, darin (slow to review), Paweł Hajdan Jr.

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Http cache: Add code to restart a network request when the server doesn't revalidate a partially stored entry, in other words, after we issued a conditional byte range request. BUG=27276, 28850 TEST=unittests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=33412

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Created: 11 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+101 lines, -28 lines)			Patch
M	net/http/http_cache_transaction.h	View		1 chunk	+5 lines, -2 lines	0 comments	Download
M	net/http/http_cache_transaction.cc	View	1 2 3 4	5 chunks	+49 lines, -23 lines	0 comments	Download
M	net/http/http_cache_unittest.cc	View		1 chunk	+42 lines, -0 lines	0 comments	Download
M	net/http/partial_data.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	net/http/partial_data.cc	View		1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

rvargas (doing something else)

The only changes from the previously reviewed code are lines 1009, 1282 and 1285.

11 years ago (2009-12-01 00:40:28 UTC) #1

eroman

ok, lgtm. please add a comment explaining why !auth_response.headers, since this is not obvious.

11 years ago (2009-12-01 01:44:33 UTC) #2

rvargas1

11 years ago (2009-12-01 01:58:23 UTC) #3

Thanks, comment :
        // If there is no callback we'll return OK to the caller so we
cannot
        // restart the request. If we have an authentication response, we
are
        // exposed to weird things hapenning if the user cancels the
        // authentication before we receive the new response.

On Mon, Nov 30, 2009 at 5:44 PM, <eroman@chromium.org> wrote:

> ok, lgtm.
>
> please add a comment explaining why !auth_response.headers, since this is
> not
> obvious.
>
>
> http://codereview.chromium.org/452017
>

Expand Messages | Collapse Messages