Issue 452012: Merge 33291 - Clear the target/action of the close button when the view goes ...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 452012: Merge 33291 - Clear the target/action of the close button when the view goes ... (Closed)

Created:
11 years ago by pink (ping after 24hrs)

Modified:
9 years, 7 months ago

Reviewers:
pink (ping after 24hrs)

CC:
chromium-reviews_googlegroups.com, John Grabowski, pam+watch_chromium.org, ben+cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/branches/249/src/

Visibility:
Public.

Description

Merge 33291 - Clear the target/action of the close button when the view goes into the closing state in an attempt to prevent errant messages to dead objects. BUG=24987 TEST=open a ton of tabs, rapidly click the close box, hope nothing crashes and the tabs still close correctly. TBR=pinkerton@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=33295

Patch Set 1 #

Created: 11 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -1 line)			Patch
	M	chrome/browser/cocoa/tab_view.h	View		1 chunk	+3 lines, -1 line	0 comments	Download
	M	chrome/browser/cocoa/tab_view.mm	View		1 chunk	+9 lines, -0 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages