Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(563)

Issue 452007: Merge 32586 - Fix unitialized memory access in workers.... (Closed)

Created:
11 years ago by levin
Modified:
9 years, 7 months ago
Reviewers:
levin
CC:
chromium-reviews_googlegroups.com, jam, ben+cc_chromium.org
Visibility:
Public.

Description

Merge 32586 - Fix unitialized memory access in workers. The primary issue was that OnDestroy didn't change the entangled port to have its entangled port be none. A secondary issues that came up is that in very rare circumstances (like a crash happening early in a worker process), it seemed like it may be possible that one of the message ports may think it is entangled and the other half may not, so the Erase method guards against this. Also, some code was added to verify the internal structure before running code and after. BUG=27839 TEST=valgrind on linux running ui tests, specifically WorkerTest.WorkerFastLayoutTests. Review URL: http://codereview.chromium.org/402106 TBR=levin@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=33271

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -6 lines) Patch
M chrome/browser/worker_host/message_port_dispatcher.h View 1 chunk +10 lines, -0 lines 0 comments Download
M chrome/browser/worker_host/message_port_dispatcher.cc View 11 chunks +61 lines, -6 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
levin
11 years ago (2009-11-30 06:51:35 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698