Fix rtl text shifting in PopupListBox

Source/web/tests/PopupMenuTest.cpp

 /*
  * Copyright (C) 2010 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 17 matching lines @@
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #include "config.h"
 
 #include "core/dom/Element.h"
 #include "core/frame/FrameView.h"
 #include "core/frame/Settings.h"
 #include "core/html/HTMLSelectElement.h"
 #include "core/page/EventHandler.h"
+#include "core/rendering/RenderMenuList.h"
 #include "platform/KeyboardCodes.h"
 #include "platform/PlatformMouseEvent.h"
 #include "platform/PopupMenu.h"
 #include "platform/PopupMenuClient.h"
 #include "platform/RuntimeEnabledFeatures.h"
 #include "platform/graphics/Color.h"
 #include "platform/scroll/ScrollbarTheme.h"
 #include "public/platform/Platform.h"
 #include "public/platform/WebScreenInfo.h"
 #include "public/platform/WebString.h"
@@ skipping 493 matching lines @@
     m_popupMenuClient.setFocusedNode(mainFrame()->frame()->document()->focusedElement());
     m_popupMenuClient.setListSize(30);
 
     showPopup();
     PopupContainer* container = webView()->selectPopup();
     PopupListBox* listBox = container->listBox();
 
     EXPECT_EQ(container->width(), listBox->contentsSize().width() + ScrollbarTheme::theme()->scrollbarThickness() + 2);
 }
 
+class SelectPopupMenuStyleTest : public testing::Test {
+public:
+    SelectPopupMenuStyleTest()
+        : baseURL("http://www.test.com/")
+    {
+    }
+
+protected:
+    virtual void SetUp() OVERRIDE
+    {
+        m_helper.initialize(false, 0, &m_webviewClient);
+    }
+
+    virtual void TearDown() OVERRIDE
+    {
+        Platform::current()->unitTestSupport()->unregisterAllMockedURLs();
+    }
+
+    // Returns true if there currently is a select popup in the WebView.
+    bool popupOpen() const { return webView()->selectPopup(); }
+
+    void registerMockedURLLoad(const std::string& fileName)
+    {
+        URLTestHelpers::registerMockedURLLoad(toKURL(baseURL + fileName), WebString::fromUTF8(fileName.c_str()), WebString::fromUTF8("popup/"), WebString::fromUTF8("text/html"));
+    }
+
+    void loadFrame(WebFrame* frame, const std::string& fileName)
+    {
+        FrameTestHelpers::loadFrame(frame, baseURL + fileName);
+    }
+
+    WebViewImpl* webView() const { return m_helper.webViewImpl(); }
+    WebLocalFrameImpl* mainFrame() const { return m_helper.webViewImpl()->mainFrameImpl(); }
+
+protected:
+    PopupTestWebViewClient m_webviewClient;
+    RefPtr<PopupMenu> m_popupMenu;
+    std::string baseURL;
+
+private:
+    FrameTestHelpers::WebViewHelper m_helper;
+};
+
+#if OS(MACOSX) || OS(ANDROID)
+TEST_F(SelectPopupMenuStyleTest, DISABLED_PopupListBoxRTLRowWidth)
+#else
+TEST_F(SelectPopupMenuStyleTest, PopupListBoxRTLRowWidth)
+#endif
+{
+    registerMockedURLLoad("select_rtl_width.html");
+    loadFrame(mainFrame(), "select_rtl_width.html");
+    HTMLSelectElement* select = toHTMLSelectElement(mainFrame()->frame()->document()->focusedElement());
+    RenderMenuList* menuList = toRenderMenuList(select->renderer());
+    ASSERT(menuList);
+    menuList->showPopup();
+    ASSERT(popupOpen());
+    PopupListBox* listBox = webView()->selectPopup()->listBox();
+    int ltrWidth = listBox->getRowBaseWidth(0);
+    int rtlWidth = listBox->getRowBaseWidth(1);
+    EXPECT_LT(rtlWidth, ltrWidth);
+}
+
 } // namespace