remoting/android/java/res/values/strings.xml - Issue 451973002: Capabilities + Extensions + Cast Host Extension Support for Android client

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: remoting/android/java/res/values/strings.xml

Issue 451973002: Capabilities + Extensions + Cast Host Extension Support for Android client (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Minor Fixes Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« remoting/android/cast/src/org/chromium/chromoting/CastExtensionHandler.java ('K') | « remoting/android/java/res/menu/desktop_actionbar.xml ('k') | remoting/android/java/src/org/chromium/chromoting/ActivityLifecycleListener.java » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <?xml version="1.0" encoding="utf-8"?>

	2 <resources>

	3

	4 <string name="media_route_menu_title">Cast</string>
	Lambros 2014/08/08 23:20:45 We shouldn't need a strings.xml file here. We shou We shouldn't need a strings.xml file here. We should add the localizable string to remoting/resources/remoting_strings.grd, and then the GRIT tool generates localized strings.xml files for us as part of the build (see the "remoting_strings" target). I wonder if this string can be pulled from the same library that holds the Cast logo image?
	5

	6 </resources>

OLD	NEW