Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Unified Diff: content/browser/service_worker/service_worker_browsertest.cc

Issue 451943003: Fix flakiness of ServiceWorkerBrowserTest.Reload by using TitleWatcher. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/service_worker/service_worker_browsertest.cc
diff --git a/content/browser/service_worker/service_worker_browsertest.cc b/content/browser/service_worker/service_worker_browsertest.cc
index 37ff625d3a2657ef99812fab05d02d02c766040f..6986d5e03126fe0f5c9000eba24cabc52f3de661 100644
--- a/content/browser/service_worker/service_worker_browsertest.cc
+++ b/content/browser/service_worker/service_worker_browsertest.cc
@@ -25,6 +25,7 @@
#include "content/public/browser/storage_partition.h"
#include "content/public/browser/web_contents.h"
#include "content/public/common/content_switches.h"
+#include "content/public/test/browser_test_utils.h"
#include "content/public/test/content_browser_test.h"
#include "content/public/test/content_browser_test_utils.h"
#include "content/shell/browser/shell.h"
@@ -670,7 +671,7 @@ IN_PROC_BROWSER_TEST_F(ServiceWorkerVersionBrowserTest, SyncEventHandled) {
EXPECT_EQ(200, response.status_code);
}
-IN_PROC_BROWSER_TEST_F(ServiceWorkerBrowserTest, DISABLED_Reload) {
+IN_PROC_BROWSER_TEST_F(ServiceWorkerBrowserTest, Reload) {
const std::string kPageUrl = "/service_worker/reload.html";
const std::string kWorkerUrl = "/service_worker/fetch_event_reload.js";
{
@@ -683,12 +684,18 @@ IN_PROC_BROWSER_TEST_F(ServiceWorkerBrowserTest, DISABLED_Reload) {
base::Bind(&ExpectResultAndRun, true, base::Bind(&base::DoNothing)));
observer->Wait();
}
- NavigateToURL(shell(), embedded_test_server()->GetURL(kPageUrl));
- EXPECT_EQ(base::UTF8ToUTF16("reload=false"),
- shell()->web_contents()->GetTitle());
- ReloadBlockUntilNavigationsComplete(shell(), 1);
- EXPECT_EQ(base::UTF8ToUTF16("reload=true"),
- shell()->web_contents()->GetTitle());
+ {
+ const base::string16 title = base::ASCIIToUTF16("reload=false");
+ TitleWatcher title_watcher(shell()->web_contents(), title);
+ NavigateToURL(shell(), embedded_test_server()->GetURL(kPageUrl));
+ EXPECT_EQ(title, title_watcher.WaitAndGetTitle());
+ }
+ {
+ const base::string16 title = base::ASCIIToUTF16("reload=true");
+ TitleWatcher title_watcher(shell()->web_contents(), title);
+ ReloadBlockUntilNavigationsComplete(shell(), 1);
+ EXPECT_EQ(title, title_watcher.WaitAndGetTitle());
+ }
shell()->Close();
{
base::RunLoop run_loop;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698