Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(304)

Issue 451943003: Fix flakiness of ServiceWorkerBrowserTest.Reload by using TitleWatcher. (Closed)

Created:
6 years, 4 months ago by horo
Modified:
6 years, 4 months ago
Reviewers:
falken
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, jam, kinuko+serviceworker, nhiroki, darin-cc_chromium.org, horo+watch_chromium.org, alecflett+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix flakiness of ServiceWorkerBrowserTest.Reload by using TitleWatcher. BUG=393486 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288301

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -7 lines) Patch
M content/browser/service_worker/service_worker_browsertest.cc View 3 chunks +14 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
horo
falken@ Please review this. Thank you.
6 years, 4 months ago (2014-08-08 01:59:27 UTC) #1
falken
I didn't know about TitleWatcher. Thanks for fixing this. lgtm
6 years, 4 months ago (2014-08-08 02:34:47 UTC) #2
horo
The CQ bit was checked by horo@chromium.org
6 years, 4 months ago (2014-08-08 02:41:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/horo@chromium.org/451943003/1
6 years, 4 months ago (2014-08-08 02:43:40 UTC) #4
commit-bot: I haz the power
6 years, 4 months ago (2014-08-08 10:12:21 UTC) #5
Message was sent while issue was closed.
Change committed as 288301

Powered by Google App Engine
This is Rietveld 408576698