Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 451923002: Add a X-Requested-With header to URL requests for PPAPI Flash (only). (Closed)

Created:
6 years, 4 months ago by Tom Sepez
Modified:
6 years, 4 months ago
Reviewers:
vtl, bbudge, brettw
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org, darin (slow to review), jschuh
Project:
chromium
Visibility:
Public.

Description

Add a X-Requested-With header to URL requests for PPAPI Flash (only). This is a revival of Trung's patch in https://codereview.chromium.org/10886047/. The difference is that we provide the header only for the Shockwave Flash plugin (plus a test plugin). BUG=145090 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290887

Patch Set 1 #

Patch Set 2 : Whitespace and comments. #

Patch Set 3 : Fix tests. #

Total comments: 4

Patch Set 4 : Address reviewer comments. #

Patch Set 5 : Fix tests #

Patch Set 6 : Avoid hitting bad cast in test. #

Total comments: 2

Patch Set 7 : add comment about -1. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+123 lines, -19 lines) Patch
M chrome/test/ppapi/ppapi_browsertest.cc View 1 2 3 4 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/test/ppapi/ppapi_test.cc View 1 chunk +10 lines, -4 lines 0 comments Download
M content/child/request_extra_data.h View 1 2 3 2 chunks +9 lines, -3 lines 0 comments Download
M content/renderer/pepper/pepper_plugin_registry.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/pepper/pepper_url_request_unittest.cc View 1 2 3 4 5 6 1 chunk +3 lines, -1 line 0 comments Download
M content/renderer/pepper/plugin_module.h View 1 3 chunks +4 lines, -1 line 0 comments Download
M content/renderer/pepper/plugin_module.cc View 1 2 4 chunks +4 lines, -2 lines 0 comments Download
M content/renderer/pepper/url_request_info_util.cc View 1 2 3 4 5 3 chunks +59 lines, -3 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 1 2 3 2 chunks +15 lines, -4 lines 0 comments Download
M content/test/ppapi_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/tests/test_url_loader.h View 1 chunk +1 line, -0 lines 0 comments Download
M ppapi/tests/test_url_loader.cc View 1 2 2 chunks +13 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
Tom Sepez
Brett, please review (you were the reviewer on the original VTL patch).
6 years, 4 months ago (2014-08-12 00:16:54 UTC) #1
brettw
lgtm https://codereview.chromium.org/451923002/diff/40001/content/child/request_extra_data.h File content/child/request_extra_data.h (right): https://codereview.chromium.org/451923002/diff/40001/content/child/request_extra_data.h#newcode99 content/child/request_extra_data.h:99: return x_requested_with_; I think trung's patch called this ...
6 years, 4 months ago (2014-08-18 21:22:48 UTC) #2
Tom Sepez
https://codereview.chromium.org/451923002/diff/40001/content/child/request_extra_data.h File content/child/request_extra_data.h (right): https://codereview.chromium.org/451923002/diff/40001/content/child/request_extra_data.h#newcode99 content/child/request_extra_data.h:99: return x_requested_with_; On 2014/08/18 21:22:48, brettw wrote: > I ...
6 years, 4 months ago (2014-08-18 22:15:24 UTC) #3
Tom Sepez
Patch set #6 addresses two issues with the tests. The first is that since only ...
6 years, 4 months ago (2014-08-19 21:31:57 UTC) #4
Tom Sepez
+bbudge for chrome/test/ppapi OWNERS review.
6 years, 4 months ago (2014-08-19 22:06:15 UTC) #5
bbudge
chrome/tests/ppapi LGTM with 2 comments. https://codereview.chromium.org/451923002/diff/100001/chrome/test/ppapi/ppapi_test.cc File chrome/test/ppapi/ppapi_test.cc (right): https://codereview.chromium.org/451923002/diff/100001/chrome/test/ppapi/ppapi_test.cc#newcode300 chrome/test/ppapi/ppapi_test.cc:300: pepper_plugin.append(FILE_PATH_LITERAL("#PPAPI Tests")); This doesn't ...
6 years, 4 months ago (2014-08-19 22:29:15 UTC) #6
Tom Sepez
On 2014/08/19 22:06:15, Tom Sepez wrote: > +bbudge for chrome/test/ppapi OWNERS review. Also content/renderer/pepper OWNERS ...
6 years, 4 months ago (2014-08-19 22:30:35 UTC) #7
Tom Sepez
> Or does the space get filtered? > Yes, exactly. > https://codereview.chromium.org/451923002/diff/100001/content/renderer/pepper/pepper_url_request_unittest.cc > File content/renderer/pepper/pepper_url_request_unittest.cc ...
6 years, 4 months ago (2014-08-19 22:31:22 UTC) #8
Tom Sepez
The CQ bit was checked by tsepez@chromium.org
6 years, 4 months ago (2014-08-20 16:39:53 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tsepez@chromium.org/451923002/120001
6 years, 4 months ago (2014-08-20 16:40:59 UTC) #10
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_tests_recipe on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-20 17:51:57 UTC) #11
commit-bot: I haz the power
6 years, 4 months ago (2014-08-20 19:23:35 UTC) #12
Message was sent while issue was closed.
Committed patchset #7 (120001) as 290887

Powered by Google App Engine
This is Rietveld 408576698